Skip to content

Report low-confidence Sinter decodes as discards - #300

Open
danielgaskins wants to merge 3 commits into
quantumlib:mainfrom
danielgaskins:fix/sinter-low-confidence
Open

danielgaskins wants to merge 3 commits into
quantumlib:mainfrom
danielgaskins:fix/sinter-low-confidence

Conversation

@danielgaskins

@danielgaskins danielgaskins commented Aug 14, 2026 •

Copy link
Copy Markdown

Compiled single-pass Tesseract decoders now append Sinter's discard byte and set it for low-confidence shots. The observable bytes stay first. The README documents errors + discards as the conservative logical failure count.

This addresses the compiled-decoder part of #297 using main's shared packing helper. Multipass already uses that helper's discard format. decode_via_files keeps the pinned Sinter file API's observable-only output.

Validation: bazel test --jobs=1 //src/... passes all 19 test targets. This includes 37 Sinter integration tests and three C++ packing tests. The changed header passes clang-format, and whitespace checks pass. Builds and tests ran on one core.

@danielgaskins

Copy link
Copy Markdown
Author

Could someone with Actions access rerun the failed jobs? The macOS failure came from the existing unseeded test_sinter_decode_surface_code statistical threshold. The new deterministic discard tests passed, as did formatting and all wheel builds.

@mhucka

mhucka commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Could someone with Actions access rerun the failed jobs? The macOS failure came from the existing unseeded test_sinter_decode_surface_code statistical threshold. The new deterministic discard tests passed, as did formatting and all wheel builds.

Done. FYI that I had to rerun it twice, actually; the first rerun saw macos succeed but linux fail; the second rerun saw the linux tests succeed. (Mentioning it in case this is useful for additional development.)

@danielgaskins

Copy link
Copy Markdown
Author

Thanks for flagging this. The compatibility tests were still using Sinter's legacy sample_decode helper, which treats the new discard byte as observable data. I updated them to use Sinter's discard-aware sampler. The Bazel target now passes in 10 consecutive runs.

@danielgaskins
danielgaskins force-pushed the fix/sinter-low-confidence branch from a196700 to 8156ba4 Compare September 17, 2026 03:33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants