[armanist]

Follow-up to #632 for #622. This pull request targets 3.1.x, so it does not close the issue; the merge of 3.1.x into master does.

What changed

• phpunit.xml: failOnWarning and failOnRisky are on, so a warning or a risky test fails the run without relying on the CI flags.
• tests/Unit/Tracer/ErrorHandlerTest.php: removed the tearDown() override that repeated the handler restore already done in AppTestCase::tearDown(). The two tests that call ErrorHandler::setup() now remove the handlers they register themselves.
• .coderabbit.yaml: CodeRabbit also reviews pull requests into maintenance branches (3.1.x, 3.2.x, ...), not only the default branch.

Why

CodeRabbit reviewed #632 only in the merge of 3.1.x into master, because it skips pull requests into other branches. These are the two valid findings from that review, and the config makes later reviews happen in the pull request of the change.

Breaking changes

None. Only test configuration and tests change.

Testing

• ErrorHandlerTest: every test now leaves the error and exception handler stacks as it found them (20 of 22 did not before).
• With failOnWarning and failOnRisky, a test that emits a warning or has no assertion makes PHPUnit exit with 1; before it exited with 0.

Notes for reviewers

• CI still passes --fail-on-warning --fail-on-risky; that is now redundant and left unchanged.
• This pull request is also the check that CodeRabbit reviews a pull request into 3.1.x.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: dbde7043-c7fd-4530-840d-7091beec93f8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!