fix: implement missing utilities and fix edge-case bugs#234
Open
stooit wants to merge 1 commit into
Open
Conversation
…ests - calculator.divide: throw on division by zero - date-utils.formatRelative: use Math.round for day diff (36h -> 2 days) - validator.isEmail: allow TLDs longer than 4 chars - validator.isUrl: parse via URL constructor (handles ports/paths/queries) - string-utils.wordCount: split on whitespace runs, ignore empties - string-utils.truncate: word-boundary truncation with ellipsis in budget - task-manager: implement remove, update, and sortBy (priority, createdAt)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across the utility library. All 60 tests now pass with no regressions and no test files modified.
Changes
src/calculator.ts—dividenow throwsError("Division by zero")when the divisor is0.src/date-utils.ts—formatRelativeusesMath.round(wasMath.floor) for the day difference, fixing the off-by-one so 36 hours reports as 2 days.src/validator.tsisEmailaccepts TLDs longer than 4 characters (e.g..museum).isUrlvalidates via theURLconstructor, correctly handling ports, paths, and query strings.src/string-utils.tswordCountsplits on runs of whitespace and ignores empty tokens.truncatetruncates at a word boundary with the ellipsis counted towardmaxLength, and handles strings shorter than the ellipsis.src/task-manager.ts— implemented/completedremove,update, andsortBy(priority high→medium→low,createdAtoldest-first).Testing
bun test→ 60 pass / 0 fail.Assumptions