fix: repair failing utility-library tests#233
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: throw on division by zero instead of returning Infinity - string-utils: fix wordCount for consecutive whitespace; implement truncate - task-manager: implement remove, update, and sortBy methods - date-utils: fix off-by-one in formatRelative (Math.floor -> Math.round) - validator: accept URLs with ports in isUrl; relax isEmail TLD length All 60 tests now pass (was 44 passing, 16 failing).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests in the TypeScript utility library (was 44 passing / 16 failing → now 60 passing / 0 failing). No test files were modified and no dependencies were added.
Changes
src/calculator.tsdivide()now throwsError("Division by zero")instead of returningInfinity.src/string-utils.tswordCount()splits on/\s+/aftertrim()so consecutive/edge whitespace no longer counts empty tokens;truncate()implemented (word-boundary cut with...).src/task-manager.tsremove,update, andsortBymethods to match expected semantics.src/date-utils.tsformatRelative()— day calculation usesMath.roundso 36h → "2 days ago".src/validator.tsisUrl()now accepts URLs with ports (e.g.http://localhost:3000);isEmail()TLD length relaxed.Verification
bun test→ 60 pass, 0 fail.test/files touched.Review notes / assumptions
reviewpass flagged one latent, non-tested edge case intruncate()(lastSpace > 0vslastSpace !== -1for a string whose only space is at index 0). Left unchanged per the "fix only what the tests require" constraint — no test exercises it. Candidate for a follow-up.