Skip to content

phy: qcom: Add Shikra QMP USB3 PHY support and enable USB PHY in Shikra DTS - #117

Open
aswinm94 wants to merge 3 commits into
qualcomm-linux:qcom-nextfrom
aswinm94:shikra-usb3
Open

phy: qcom: Add Shikra QMP USB3 PHY support and enable USB PHY in Shikra DTS#117
aswinm94 wants to merge 3 commits into
qualcomm-linux:qcom-nextfrom
aswinm94:shikra-usb3

Conversation

@aswinm94

Copy link
Copy Markdown

This PR enables USB3 PHY support on the Qualcomm Shikra platform by integrating the newly added QMP USB3 PHY driver and updating the platform configuration and device tree accordingly.

upstream-link: https://marc.info/?l=u-boot&m=178668450932771&w=2

Comment thread drivers/phy/qcom/Kconfig
@@ -47,6 +47,13 @@ config PHY_QCOM_QMP_USB
Enable this to support the QMP USB PHY transceiver that is used

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In commit log give the linux version info

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mentioned the linux kernel version from where the driver is referred

status = qmp->pcs + QPHY_V3_PCS_PCS_STATUS;
ret = readl_poll_timeout(status, val, !(val & PHYSTATUS),
PHY_INIT_COMPLETE_TIMEOUT);
PHY_INIT_COMPLETE_TIMEOUT);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discard

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discarded this from the commit

Shikra USB3 QMP PHY uses a single-PHY DT binding (#phy-cells = <0>),
which is not supported by the existing QMP combo PHY driver.

Add a dedicated USB3-only QMP PHY driver for Shikra, porting the PHY
initialization sequence and configuration tables from Linux(7.2v)
drivers/phy/qualcomm/phy-qcom-qmp-usbc.c. The driver is selected
through PHY_QCOM_QMP_USB3_LEGACY and enables USB3 PHY bring-up on
Shikra platforms.

Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
Enable the QMP USB3 PHY driver in the Qualcomm common defconfig.

This allows USB3 PHY initialization support when the corresponding
platform DT is enabled.

Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
Enable the USB QMP PHY node in the U-Boot device trees for the
Shikra IQS EVK platform. This allows the QMP USB3 PHY driver to
probe and initialize the USB3 PHY during boot.

Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants