phy: qcom: Add Shikra QMP USB3 PHY support and enable USB PHY in Shikra DTS - #117
Open
aswinm94 wants to merge 3 commits into
Open
phy: qcom: Add Shikra QMP USB3 PHY support and enable USB PHY in Shikra DTS#117aswinm94 wants to merge 3 commits into
aswinm94 wants to merge 3 commits into
Conversation
varada-qcom
reviewed
Aug 17, 2026
| @@ -47,6 +47,13 @@ config PHY_QCOM_QMP_USB | |||
| Enable this to support the QMP USB PHY transceiver that is used | |||
There was a problem hiding this comment.
In commit log give the linux version info
Author
There was a problem hiding this comment.
mentioned the linux kernel version from where the driver is referred
varada-qcom
reviewed
Aug 17, 2026
| status = qmp->pcs + QPHY_V3_PCS_PCS_STATUS; | ||
| ret = readl_poll_timeout(status, val, !(val & PHYSTATUS), | ||
| PHY_INIT_COMPLETE_TIMEOUT); | ||
| PHY_INIT_COMPLETE_TIMEOUT); |
Author
There was a problem hiding this comment.
Discarded this from the commit
varada-qcom
requested changes
Aug 17, 2026
Shikra USB3 QMP PHY uses a single-PHY DT binding (#phy-cells = <0>), which is not supported by the existing QMP combo PHY driver. Add a dedicated USB3-only QMP PHY driver for Shikra, porting the PHY initialization sequence and configuration tables from Linux(7.2v) drivers/phy/qualcomm/phy-qcom-qmp-usbc.c. The driver is selected through PHY_QCOM_QMP_USB3_LEGACY and enables USB3 PHY bring-up on Shikra platforms. Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
Enable the QMP USB3 PHY driver in the Qualcomm common defconfig. This allows USB3 PHY initialization support when the corresponding platform DT is enabled. Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
Enable the USB QMP PHY node in the U-Boot device trees for the Shikra IQS EVK platform. This allows the QMP USB3 PHY driver to probe and initialize the USB3 PHY during boot. Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
varada-qcom
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables USB3 PHY support on the Qualcomm Shikra platform by integrating the newly added QMP USB3 PHY driver and updating the platform configuration and device tree accordingly.
upstream-link: https://marc.info/?l=u-boot&m=178668450932771&w=2