Skip to content

[qcom-next] clk: qcom: sa8775p: enable GPLL9 before SDCC1 high-speed rates - #115

Open
balajiselvanathan wants to merge 1 commit into
qualcomm-linux:qcom-nextfrom
balajiselvanathan:qc/sa8775p-gpll9-sdcc1
Open

[qcom-next] clk: qcom: sa8775p: enable GPLL9 before SDCC1 high-speed rates#115
balajiselvanathan wants to merge 1 commit into
qualcomm-linux:qcom-nextfrom
balajiselvanathan:qc/sa8775p-gpll9-sdcc1

Conversation

@balajiselvanathan

Copy link
Copy Markdown

On lemans/sa8775p, the SDCC1 apps clock high-speed rates (192 and 384 MHz) source from GPLL9 (ftbl_gcc_sdcc1_apps_clk_src), but the driver never enables GPLL9. When SDCC1 is set to such a rate the RCG switches its source to a PLL that is off, so the CMD_RCGR update bit never self-clears and U-Boot warns:

WARNING: RCG @ 0x120014 stuck at off

Vote GPLL9 on before selecting it as the SDCC1 source, mirroring how clock-sm8250.c enables GPLL9 for SDCC2. GPLL9's mode/status register is at 0x9000 (lock is bit 31) and its enable vote is bit 9 of the APCS GPLL vote register 0x4b028, matching gcc-sa8775p.c in Linux.

Not hardware-validated for SDCC high speed: the board this was found on (Qualcomm IQ-9075 / Lemans EVK) boots from UFS with no SD card populated, so here it only clears the stuck-RCG warning. Build-tested on lemans.
Reviewed-by: Casey Connolly casey.connolly@linaro.org

Upstream link: https://lore.kernel.org/u-boot/20260708170228.621618-1-royzah@gmail.com/

On lemans/sa8775p, the SDCC1 apps clock high-speed rates (192 and 384 MHz)
source from GPLL9 (ftbl_gcc_sdcc1_apps_clk_src), but the driver never enables
GPLL9. When SDCC1 is set to such a rate the RCG switches its source to a PLL
that is off, so the CMD_RCGR update bit never self-clears and U-Boot warns:

  WARNING: RCG @ 0x120014 stuck at off

Vote GPLL9 on before selecting it as the SDCC1 source, mirroring how
clock-sm8250.c enables GPLL9 for SDCC2. GPLL9's mode/status register is at
0x9000 (lock is bit 31) and its enable vote is bit 9 of the APCS GPLL vote
register 0x4b028, matching gcc-sa8775p.c in Linux.

Not hardware-validated for SDCC high speed: the board this was found on
(Qualcomm IQ-9075 / Lemans EVK) boots from UFS with no SD card populated, so
here it only clears the stuck-RCG warning. Build-tested on lemans.

Signed-off-by: Royyan Zahir <royzah@gmail.com>
Reviewed-by: Casey Connolly <casey.connolly@linaro.org>
Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants