[qcom-next] phy: qcom: qmp-combo: honor USB-C orientation for port select - #112
Open
balajiselvanathan wants to merge 1 commit into
Open
Conversation
Read the USB-C cable orientation from the orientation-gpios
property on the qcom,pmic-glink node and use it when programming
the TypeC port-select mux.
Taken from Linux commit 815891eee668 ("phy: qcom-qmp-combo: Introduce orientation variable")
Previously the driver always set SW_PORTSELECT_MUX without
accounting for cable orientation, so the SuperSpeed/DP lanes could
be routed to the wrong side of the connector on boards where the
cable was flipped. Now orientation is read once during DT parsing
and SW_PORTSELECT_VAL is added to the mux value when a reversed
orientation is detected.
Tested on QCS6490 RB3 Gen2 board.
Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
varada-qcom
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read the USB-C cable orientation from the orientation-gpios property on the qcom,pmic-glink node and use it when programming the TypeC port-select mux.
Taken from Linux commit 815891eee668 ("phy: qcom-qmp-combo: Introduce orientation variable")
Previously the driver always set SW_PORTSELECT_MUX without accounting for cable orientation, so the SuperSpeed/DP lanes could be routed to the wrong side of the connector on boards where the cable was flipped. Now orientation is read once during DT parsing and SW_PORTSELECT_VAL is added to the mux value when a reversed orientation is detected.
Tested on QCS6490 RB3 Gen2 board.
Upstream link: https://lore.kernel.org/u-boot/20260724-kodiak_ss_orientation-v1-1-d9d8fd271e0c@oss.qualcomm.com/