fastrpc-test :enable tests on QRB2210, Glymur CRD, and SM8850 - #532
Open
anankulk wants to merge 1 commit into
Open
fastrpc-test :enable tests on QRB2210, Glymur CRD, and SM8850#532anankulk wants to merge 1 commit into
anankulk wants to merge 1 commit into
Conversation
Remove SoC-specific skip-all entries for QRB2210 and Glymur CRD so both targets run through the same runtime domain-discovery path as all other boards. Remove the SM8850 special-case that silently counted libhap_example HAP_mem DMA failures as known skips; failures now surface as real failures consistent with all other targets. Signed-off-by: Anand Kulkarni <anankulk@qti.qualcomm.com>
Tharun Kumar Merugu (quic-mtharu)
approved these changes
Aug 11, 2026
Srikanth Muppandam (smuppand)
requested changes
Aug 11, 2026
Srikanth Muppandam (smuppand)
left a comment
Srikanth Muppandam (smuppand)
left a comment
Contributor
There was a problem hiding this comment.
only_hap_example_failed() now has no callers and still documents the SM8850 exception being removed. Remove the function and obsolete comment in this PR.
|
|
||
| case "$SOC_MACHINE" in | ||
| *QRB2210*|*"Glymur CRD"*) |
Contributor
There was a problem hiding this comment.
QRB2210 and Glymur now reach generic discovery, but discover_supported_domains() checks remoteproc/DT presence—not whether the corresponding FastRPC endpoint, libraries, and skeletons are usable. Runtime-layout discovery merely warns when artifacts are absent.
| # Do not skip Glymur CRD by SoC name. Newer Glymur/Debian images expose | ||
| # ADSP/CDSP remoteproc instances and FastRPC skeletons, so runtime discovery | ||
| # should decide whether the test can run. | ||
| soc_skip_all=0 |
Contributor
There was a problem hiding this comment.
soc_skip_all is initialized to 0 but can no longer become 1.Remove soc_skip_all and its block at lines 251–255 rename the section to describe the remaining GPDSP filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fastrpc-test: enable tests on QRB2210, Glymur CRD, and SM8850
QRB2210 and Glymur CRD were previously skipped entirely via a SoC-level
block in
run.sh. Both targets are now enabled and go through the sameruntime domain discovery and test execution path as all other supported
boards.
SM8850 had a special-case branch that treated
libhap_exampleHAP_memDMA failures as known skips, masking them as passes. That exception is
removed; results on SM8850 are now reported consistently with all other
targets.
GPDSP0/GPDSP1 skip on QCS9075, QCS8275, QCS8300, QCS9100 is unchanged.