OpenCV: fix LAVA YAML flag argument handling#481
Merged
Conversation
The OpenCV LAVA definition passes boolean option values directly to run.sh, for example "--list 0" and "--shuffle 0". The OpenCV runner treats these as flag-style options, so "--list 0" enables list-only mode and leaves the trailing "0" as an unknown argument. This causes the suite to run with --gtest_list_tests by default instead of executing the tests. Update OpenCV.yaml while preserving the existing direct run.steps style: - pass --list only when LIST_ONLY=1 - pass --shuffle only when SHUFFLE=1 - pass --seed only when SEED is set - use TIMEOUT_SECS consistently - use PERF_TO_TESTS consistently - use the correct --perf-to-tests option name This removes unknown argument warnings and ensures the default LAVA run executes OpenCV tests instead of only listing them. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
OpenCV.yamlargument handling so the OpenCV LAVA job no longer passes values to flag-style[run.sh](http://run.sh/)options.The current YAML passes boolean values directly to flag options: