ci: keep ShellCheck strict for all shell files#480
Merged
Conversation
The previous workflow special-cased Runner/utils/functestlib.sh to ignore SC2317. The reported SC2317 issues were caused by duplicate helper entries rather than a required library lint exception. Remove the functestlib-specific SC2317 exclusion and keep ShellCheck strict for all shell files. Preserve the existing workflow behavior: changed shell files are linted on pull requests, while push/manual runs lint the full shell tree. Keep the PR branch hardening by passing github.base_ref through an environment variable and validating it with git check-ref-format before using it in git fetch. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
bhargav0610
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
[functestlib.sh](http://functestlib.sh/)-specificSC2317exception from the ShellCheck workflow and keep ShellCheck strict for all shell files.Why
The earlier
SC2317failures inRunner/utils/[functestlib.sh](http://functestlib.sh/)were caused by duplicate helper entries, not because the workflow needed a permanent exception for[functestlib.sh](http://functestlib.sh/).Since the duplicate entries have been addressed,
[functestlib.sh](http://functestlib.sh/)should be linted with the same ShellCheck policy as the rest of the repository.