arm64: dts: qcom: camera: Add support for rgbir camera

[khatri-nirav]

Add support for RGBIR camera dt node as sensor 12.

CRs-Fixed: 4632351

[qswat-orbit-external]

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4632351 on any of the following entities:

Entities:

• kernel.qli.2.0

CR: 4632351

Please ensure the CR has a change task associated with at least one of the entities for this branch.

[qswat-orbit-external]

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4632351 on any of the following entities:

Entities:

• kernel.qli.2.0

CR: 4632351

Please ensure the CR has a change task associated with at least one of the entities for this branch.

[qswat-orbit-external]

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4632351 on any of the following entities:

Entities:

• kernel.qli.2.0

CR: 4632351

Please ensure the CR has a change task associated with at least one of the entities for this branch.

[qlijarvis]

PR #954 — validate-patch

PR: #954

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

1. Lore link present: No — no lore.kernel.org link found; appears to be vendor-specific change based on CRs-Fixed tag
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — no upstream link provided; likely vendor-only change not posted upstream
4. PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #954 - arm64: dts: qcom: camera: Add support for rgbir camera
Upstream commit: N/A
Verdict: ❌ FAIL

Commit Message

Check	Status	Note
Subject matches upstream	N/A	No upstream link provided
Body preserves rationale	⚠️	Minimal description; no technical rationale
Fixes tag present/correct	N/A	Not a fix; no Fixes tag expected
Authorship preserved	N/A	No upstream to compare against
Backport note (if applicable)	N/A	Not a backport
Commit prefix	❌	Missing required prefix (QCLINUX/PENDING/WORKAROUND for vendor-only)

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi	⚠️	Adds new sensor node + removes pwm-switch property

Issues

1. Missing lore.kernel.org link: No Link: tag found in commit message. This patch appears to be vendor-specific (contains CRs-Fixed: 4632351 internal reference) but lacks the required QCLINUX: prefix.

2. Missing commit prefix: Commit subject should start with one of:

   • QCLINUX: — for vendor-only changes not intended for upstream
   • PENDING: — for work-in-progress not yet posted
   • UPSTREAM: / FROMLIST: / BACKPORT: — for upstream-sourced changes (requires lore link)

3. Incomplete commit message: The description "Add support for RGBIR camera dt node as sensor 12" lacks technical detail:

   • What is the sensor model? (Comment says ov2778)
   • Why is this sensor needed?
   • What hardware configuration does this support?
   • Why remove pwm-switch from sensor 11?

4. Unrelated change bundled: The patch removes pwm-switch property from qcom,cam-sensor11 (line 269) while adding a new sensor node. These should be separate commits with individual justifications.

5. Partial integration presence: Integration report shows this change is only partially present in qcom-next (35/38 lines matched). The missing lines are the comment and first two properties of the new sensor node, suggesting the PR may contain modifications to an existing qcom-next commit.

Verdict

Do not merge without corrections. This commit requires:

1. Add QCLINUX: prefix to subject if vendor-only, or provide lore link if upstream-sourced
2. Split into two commits: (a) remove pwm-switch from sensor 11, (b) add sensor 12
3. Expand commit message with technical rationale
4. Reconcile with qcom-next content (verify why 3 lines differ)

Final Summary

1. Lore link present: No — no lore.kernel.org link found; appears to be vendor-specific change based on CRs-Fixed tag
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — no upstream link provided; likely vendor-only change not posted upstream
4. PR present in qcom-next/topics: Partial — 35/38 added lines present in qcom-next; 3 lines missing (comment /* cam3-slot - ov2778 */ and first two properties of sensor node). This suggests the PR may be modifying an existing qcom-next commit rather than introducing entirely new content.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 49dbe0dae5cfb7a1eb3434cde6fc7ba37924fe94
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] arm64: dts: qcom: camera: Add support for rgbir camera	partial - subject or partial tree evidence found, but full change was not verified	missing - no subject, patch-id, or full tree-content match found	partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

[qlijarvis]

PR #954 — checker-log-analyzer

PR: #954
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31795669946

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	1 warning: undocumented DT compatible string
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	❌	Multiple schema validation failures for qcom,cam-sensor
sparse-check	⏭️	Skipped (no C/H changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Missing required subject prefix (mandatory for qcom-6.18.y)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #954 - arm64: dts: qcom: camera: Add support for rgbir camera
Target branch: qcom-6.18.y
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/31795669946

Checker	Result	Summary
checkpatch	❌	1 warning: undocumented DT compatible string
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	❌	Multiple schema validation failures for qcom,cam-sensor
sparse-check	⏭️	Skipped (no C/H changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Missing required subject prefix (mandatory for qcom-6.18.y)

---

❌ checkpatch

Root cause: The compatible string "qcom,cam-sensor" is not documented in the kernel's vendor prefix registry.

Failure details:

Commit 432c1b3cf303 ("arm64: dts: qcom: camera: Add support for rgbir camera")
WARNING: DT compatible string "qcom,cam-sensor" appears un-documented -- check ./Documentation/devicetree/bindings/
#34: FILE: arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi:480:
+		compatible = "qcom,cam-sensor";

432c1b3cf3030c4ab3a0f9f1ec5986b4fec5237e total: 0 errors, 1 warnings, 0 checks, 51 lines checked

Fix: Add a device tree binding YAML file for qcom,cam-sensor at Documentation/devicetree/bindings/media/qcom,cam-sensor.yaml (or similar path), or add the compatible string to an existing binding if this is a generic camera sensor node.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git bfeb0e5567c0987f05faeec78664719b718133e5..432c1b3cf3030c4ab3a0f9f1ec5986b4fec5237e

---

❌ dtb-check

Root cause: The qcom,cam-sensor compatible string has no matching device tree binding schema, causing multiple validation failures.

Failure details:

arch/arm64/boot/dts/qcom/qcs5430-fps-camx.dtb: /soc@0/qcom,cci1/qcom,cam-sensor12: failed to match any schema with compatible: ['qcom,cam-sensor']

qcom,cci1 (qcom,cci): qcom,cam-sensor12: 'ranges' is a required property

qcom,cam-sensor12 (qcom,cam-sensor): gpio-req-tbl-label: b'CAMIF_MCLK3^@CAM_RESET3^@' is not of type 'object', 'integer', 'array', 'boolean', 'null'

qcom,cam-sensor12 (qcom,cam-sensor): status: 'oneOf' conditional failed, one must be fixed

Analysis: These are new errors introduced by this PR. The dtb-check baseline subtraction shows these errors were not present before. The root cause is that qcom,cam-sensor has no binding YAML, so the schema validator cannot validate any of the node's properties.

Fix: Create a complete device tree binding for qcom,cam-sensor at Documentation/devicetree/bindings/media/qcom,cam-sensor.yaml that declares all the properties used in this node:

• compatible
• cell-index
• csiphy-sd-index
• sensor-position-roll, sensor-position-pitch, sensor-position-yaw
• cam_vio-supply
• regulator-names
• power-domains
• rgltr-cntrl-support
• rgltr-min-voltage, rgltr-max-voltage, rgltr-load-current
• gpio-no-mux
• pinctrl-*
• gpios
• gpio-reset, gpio-req-tbl-num, gpio-req-tbl-flags, gpio-req-tbl-label
• sensor-mode
• cci-master
• clocks, clock-names, clock-cntl-level, clock-rates
• status
• ranges (if required by the parent qcom,cci binding)

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs5430-fps-camx.dtb
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine-camx.dtb

---

❌ check-patch-compliance

Root cause: The commit subject does not start with a required prefix tag.

Failure details:

Checking commit: arm64: dts: qcom: camera: Add support for rgbir camera
Commit summary does not start with a required prefix

Fix: Add a valid prefix to the commit subject. Since this is a device tree change with no upstream equivalent (vendor-specific camera node), use QCLINUX::

git rebase -i bfeb0e5567c0987f05faeec78664719b718133e5
# mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: camera: Add support for rgbir camera

Add support for RGBIR camera dt node as sensor 12.

CRs-Fixed: 4632351

Signed-off-by: Nirav Khatri <khatri@qti.qualcomm.com>"
git rebase --continue

Note: QCLINUX: is the correct prefix for vendor-only changes. However, be aware that check-patch-compliance only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:), so this checker will continue to fail even after adding QCLINUX:. This is a known limitation of the checker for vendor-only commits.

---

❌ tag-check

Root cause: The commit subject does not start with a required prefix tag. This check is mandatory for the target branch qcom-6.18.y (all branches except qcom-next and qcom-next-staging require a prefix).

Failure details:

Commit 432c1b3cf303 ("arm64: dts: qcom: camera: Add support for rgbir camera"): subject line does not start with a required prefix.
All branches except qcom-next and qcom-next-staging require one of:
FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix: Same as check-patch-compliance above — add QCLINUX: prefix to the commit subject:

git commit --amend -m "QCLINUX: arm64: dts: qcom: camera: Add support for rgbir camera"

---

Verdict

3 blockers must be fixed before merge:

1. Add QCLINUX: prefix to the commit subject (fixes both check-patch-compliance and tag-check)
2. Create a device tree binding for qcom,cam-sensor to fix checkpatch and dtb-check failures
3. Ensure the binding declares all properties used in the DTS node, including ranges if required by the parent CCI node

Recommended action order:

1. Add the QCLINUX: prefix to the commit subject
2. Create Documentation/devicetree/bindings/media/qcom,cam-sensor.yaml with all required properties
3. Re-run CI to verify all checkers pass

[qlijarvis]

PR #954 — validate-patch

PR: #954

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

1. Lore link present: No — no lore.kernel.org link found in commit message or Link: tag
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — cannot determine without lore link; likely vendor-only based on CRs-Fixed tag
4. PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

Recommendation: Reject and request rework. The commit must be split, properly prefixed, and documented before it can be merged.

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #954 - arm64: dts: qcom: camera: Add support for rgbir camera
Upstream commit: N/A (no lore.kernel.org link found)
Verdict: ❌ FAIL

Commit Message

Check	Status	Note
Subject matches upstream	N/A	No upstream link to compare
Body preserves rationale	❌	Minimal description; no technical rationale for changes
Fixes tag present/correct	N/A	Not a fix commit
Authorship preserved	N/A	No upstream to verify against
Backport note (if applicable)	N/A	Not a backport
Commit prefix	❌	Missing required prefix (UPSTREAM:/FROMLIST:/BACKPORT:/QCLINUX:/PENDING:/WORKAROUND:)

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi	❌	Two unrelated changes: (1) removes pwm-switch property from existing sensor, (2) adds new cam-sensor14 node — should be split into separate commits

Issues

Critical Issues:

1. No lore.kernel.org link — The commit message lacks a Link: tag pointing to lore.kernel.org. Per the validate-patch skill Step 1, commits without a lore link cannot be validated against upstream sources unless they use a vendor-only prefix.

2. Missing commit prefix — The subject line lacks a required prefix:

   • If this is vendor-only work → use QCLINUX: prefix
   • If posted to mailing list → use FROMLIST: prefix + add lore link
   • If merged upstream → use UPSTREAM: or BACKPORT: prefix + add lore/git link
   • If work-in-progress → use PENDING: prefix

3. Multiple unrelated changes in one commit — The patch contains two distinct changes:

   • Change 1: Removes pwm-switch; property from an existing camera sensor node (line 269)
   • Change 2: Adds a new qcom,cam-sensor14 node for RGBIR camera (ov2778) with full configuration (39 new lines)

   These should be split into separate commits with individual justifications.

4. Commit message discrepancy — The subject says "Add support for rgbir camera" and body says "sensor 12", but the code adds cam-sensor14 with cell-index = <14>. The sensor numbering is inconsistent.

5. Insufficient commit message — The body provides no technical rationale:

   • Why is pwm-switch being removed from the existing sensor?
   • What hardware does this RGBIR camera correspond to?
   • Why is it configured as sensor 14 when the message says sensor 12?
   • What is the relationship between the two changes?

6. Vendor-specific tag — CRs-Fixed: 4632351 is a Qualcomm internal CR tag. If this is vendor-only work, the commit should use the QCLINUX: prefix to signal that no upstream link is expected.

Verdict

Do not merge without correction. This commit violates multiple kernel coding standards:

1. Split the commit into two separate patches:

   • Patch 1: Remove pwm-switch from existing sensor (with rationale explaining why)
   • Patch 2: Add RGBIR camera sensor 14 support (with hardware details)

2. Add the appropriate prefix to the subject line:

   • If vendor-only → QCLINUX: arm64: dts: qcom: camera: Add support for rgbir camera
   • If upstream-bound → FROMLIST: arm64: dts: qcom: camera: Add support for rgbir camera + add lore link

3. Fix the sensor numbering inconsistency — Either update the commit message to say "sensor 14" or explain why the message says "sensor 12" when the code uses index 14.

4. Expand the commit message to explain:

   • Hardware context (which board/connector)
   • Why pwm-switch is being removed (if kept in same commit)
   • Technical justification for the configuration choices

Final Summary

1. Lore link present: No — no lore.kernel.org link found in commit message or Link: tag
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — cannot determine without lore link; likely vendor-only based on CRs-Fixed tag
4. PR present in qcom-next/topics: Partial — integration_presence_report.md shows "partial - subject or partial tree evidence found, but full change was not verified" in qcom-next; missing from topics. This suggests the commit may exist in a different form or the changes are partially present, but the exact commit is not verified.

Recommendation: Reject and request rework. The commit must be split, properly prefixed, and documented before it can be merged.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 49dbe0dae5cfb7a1eb3434cde6fc7ba37924fe94
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] arm64: dts: qcom: camera: Add support for rgbir camera	partial - subject or partial tree evidence found, but full change was not verified	missing - no subject, patch-id, or full tree-content match found	partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

[qlijarvis]

PR #954 — checker-log-analyzer

PR: #954
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31798170475

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	Undocumented DT compatible string
dt-binding-check	⏭️	No binding changes
dtb-check	❌	Missing binding for qcom,cam-sensor
sparse-check	⏭️	No C/H changes
check-uapi-headers	⏭️	No UAPI changes
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Missing required subject prefix (qcom-6.18.y branch)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #954 - arm64: dts: qcom: camera: Add support for rgbir camera
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/31798170475
Target Branch: qcom-6.18.y
Commit: 614ecc4

Checker	Result	Summary
checkpatch	❌	Undocumented DT compatible string
dt-binding-check	⏭️	No binding changes
dtb-check	❌	Missing binding for qcom,cam-sensor
sparse-check	⏭️	No C/H changes
check-uapi-headers	⏭️	No UAPI changes
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Missing required subject prefix (qcom-6.18.y branch)

---

❌ checkpatch

Root cause: The compatible string qcom,cam-sensor is not documented in Documentation/devicetree/bindings/vendor-prefixes.yaml or lacks a binding YAML file.

Failure details:

WARNING: DT compatible string "qcom,cam-sensor" appears un-documented -- check ./Documentation/devicetree/bindings/
#34: FILE: arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi:480:
+		compatible = "qcom,cam-sensor";

614ecc4ba9f84b45ee328eab30c11bfde032f361 total: 0 errors, 1 warnings, 0 checks, 52 lines checked

Fix: This warning is directly related to the missing DT binding (see dtb-check below). The compatible string qcom,cam-sensor needs a proper binding YAML file in Documentation/devicetree/bindings/. Once the binding is added, this checkpatch warning will be resolved.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git bfeb0e5567c0987f05faeec78664719b718133e5..614ecc4ba9f84b45ee328eab30c11bfde032f361

---

❌ dtb-check

Root cause: No DT binding schema exists for the compatible string qcom,cam-sensor, causing multiple validation failures.

Failure details:

Log Summary: Test failed
/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/qcs5430-fps-camx.dtb: qcom,cci1 (qcom,cci): qcom,cam-sensor14: 'ranges' is a required property
arch/arm64/boot/dts/qcom/qcs5430-fps-camx.dtb: /soc@0/qcom,cci1/qcom,cam-sensor14: failed to match any schema with compatible: ['qcom,cam-sensor']
/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/qcs5430-fps-camx.dtb: qcom,cam-sensor14 (qcom,cam-sensor): gpio-req-tbl-label: b'CAMIF_MCLK3\x00CAM_RESET3\x00' is not of type 'object', 'integer', 'array', 'boolean', 'null'

The same errors appear for:

• qcs5430-fps-camx.dtb
• qcs6490-rb3gen2-vision-mezzanine-camx.dtb

Fix: Create a DT binding YAML file for qcom,cam-sensor:

1. Add Documentation/devicetree/bindings/media/qcom,cam-sensor.yaml with proper schema definition including:

   • compatible property with qcom,cam-sensor
   • All required properties: cell-index, csiphy-sd-index, sensor-position-*, regulators, GPIOs, clocks, etc.
   • Proper gpio-req-tbl-label type definition (should be an array of strings)
   • ranges property if the node is expected to have child nodes

2. The binding should follow the pattern of existing Qualcomm camera sensor bindings in the tree.

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs5430-fps-camx.dtb
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine-camx.dtb

---

❌ check-patch-compliance

Root cause: The commit subject line does not start with a required prefix tag.

Failure details:

Checking commit: arm64: dts: qcom: camera: Add support for rgbir camera
Commit summary does not start with a required prefix

Fix: Add an appropriate subject prefix based on the patch origin:

git rebase -i bfeb0e5567c0987f05faeec78664719b718133e5
# mark commit 614ecc4ba9f8 as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: camera: Add support for rgbir camera"
# (keep the rest of the commit message body unchanged)
git rebase --continue

Prefix selection guide:

Prefix	Use when
FROMLIST:	Patch posted to lore.kernel.org mailing list
FROMGIT:	Patch taken from a maintainer git tree
UPSTREAM:	Patch merged into Linus's mainline tree
BACKPORT:	Upstream patch backported with modifications
QCLINUX:	Vendor-only change with no upstream equivalent
PENDING:	Work-in-progress, not yet posted upstream
WORKAROUND:	Temporary fix not suitable for upstream

Note: If you use QCLINUX: or PENDING:, the check-patch-compliance checker will always fail because it only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:). This is a known limitation. For vendor-only camera sensor additions like this, QCLINUX: is the appropriate prefix even though the checker will flag it.

Reproduce locally:

# The checker script is in kernel-checkers repo
bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . \
  --base bfeb0e5567c0987f05faeec78664719b718133e5 \
  --head 614ecc4ba9f84b45ee328eab30c11bfde032f361

---

❌ tag-check

Root cause: The target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), which requires every commit subject to start with a valid prefix tag. The current commit has no prefix.

Failure details:

Commit 614ecc4ba9f84b45ee328eab30c11bfde032f361 ("arm64: dts: qcom: camera: Add support for rgbir camera"): subject line does not start with a required prefix.

All branches except qcom-next and qcom-next-staging require one of:
FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix: Same as check-patch-compliance above — add a subject prefix. Since this is a vendor-specific camera sensor addition with no upstream equivalent, use QCLINUX::

git rebase -i bfeb0e5567c0987f05faeec78664719b718133e5
# mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: camera: Add support for rgbir camera"
git rebase --continue

---

Verdict

3 blockers must be fixed before merge:

1. Add DT binding YAML — Create Documentation/devicetree/bindings/media/qcom,cam-sensor.yaml to document the qcom,cam-sensor compatible string and all its properties. This will resolve both the checkpatch warning and the dtb-check failures.

2. Add subject prefix — Prepend QCLINUX: to the commit subject line to satisfy both check-patch-compliance and tag-check requirements for the qcom-6.18.y branch.

3. Note on check-patch-compliance: If you use QCLINUX: prefix (appropriate for vendor-only changes), the check-patch-compliance checker will still fail because it only accepts upstream-linkable prefixes. This is a known limitation of the checker for vendor-specific commits. The tag-check requirement is satisfied, which is the mandatory policy for non-qcom-next branches.

Recommended action order:

1. Add the DT binding YAML file in a separate commit (best practice: bindings before users)
2. Amend the camera sensor commit to add QCLINUX: prefix
3. Re-run CI to verify all checkers pass (except check-patch-compliance, which will still fail for QCLINUX: — this is expected)