Skip to content

BACKPORT change to install DT overlays via dtbs_install#654

Draft
vishwasudupa wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
vishwasudupa:bp/install_dtb
Draft

BACKPORT change to install DT overlays via dtbs_install#654
vishwasudupa wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
vishwasudupa:bp/install_dtb

Conversation

@vishwasudupa
Copy link
Copy Markdown

@vishwasudupa vishwasudupa commented Jun 4, 2026

Overlay binaries (.dtbo) are currently only built implicitly as
dependencies of composite firmware images and are therefore absent from the
kernel install output.

Even when final DTBs are produced at build time, some distributions rely on
standalone DTBOs for runtime selection and application by bootloaders or
firmware. Without explicit install targets, DTBOs are not picked up by the
standard dtbs_install flow and therefore cannot be packaged alongside DTBs.

BACKPORT change to add dtb-$(CONFIG_ARCH_QCOM) entries for all DT overlays defined in
this Makefile so they are installed via dtbs_install, matching existing
DTB install behavior.

CRs-Fixed: 4561683

…stall

Overlay binaries (.dtbo) are currently only built implicitly as
dependencies of composite firmware images and are therefore absent from the
kernel install output.

Even when final DTBs are produced at build time, some distributions rely on
standalone DTBOs for runtime selection and application by bootloaders or
firmware. Without explicit install targets, DTBOs are not picked up by the
standard dtbs_install flow and therefore cannot be packaged alongside DTBs.

Add explicit dtb-$(CONFIG_ARCH_QCOM) entries for all DT overlays defined in
this Makefile so they are installed via dtbs_install, matching existing
DTB install behaviour.

Link: https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com
Signed-off-by: Vishwas Udupa <vudupa@qti.qualcomm.com>
(cherry picked from commit 7998dbf)
Install Qualcomm camx DTBO overlay files by adding them
to the dtb-$(CONFIG_ARCH_QCOM) build/install list

This makes DTBOs available through the standard dtbs_install
flow and ensures they are included in distro kernel packages

Signed-off-by: Vishwas Udupa <vudupa@qti.qualcomm.com>
(cherry picked from commit abfeee7)
@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis
Copy link
Copy Markdown

PR #654 — validate-patch

PR: #654

Verdict Issues Detailed Report
⚠️ 5 Full report

Final Summary

Commit 1/2 (FROMLIST):

  1. Lore link present: Yes — https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com
  2. Lore link matches PR commits: Cannot verify — lore.kernel.org unreachable due to network restrictions
  3. Upstream patch status: Cannot verify — network restricted; FROMLIST prefix indicates patch posted but not yet merged at time of backport
  4. PR present in qcom-next: Not checked — would require kernel tree access (explicitly prohibited in constraints)

Commit 2/2 (QCLINUX):

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #654
Commits: 2 patches (1 FROMLIST + 1 QCLINUX vendor-only)
Verdict: ⚠️ PARTIAL


Commit 1/2: BACKPORT: FROMLIST: arm64: dts: qcom: install DT overlays via dtbs_install

Upstream commit: https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com
Cherry-picked from: 7998dbf

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - lore.kernel.org unreachable (network restricted)
Body preserves rationale Clear explanation of DTBO install problem and solution
Fixes tag present/correct N/A No Fixes tag (not a bugfix)
Authorship preserved Vishwas Udupa vudupa@qti.qualcomm.com consistent
Backport note (if applicable) Cherry-pick note present with source SHA

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds 18 DTBO install targets; pattern consistent

DTBO files added (18):

  • apq8016-sbc-d3-camera-mezzanine.dtbo
  • apq8016-sbc-usb-host.dtbo
  • lemans-evk-camera-csi1-imx577.dtbo
  • lemans-evk-ifp-mezzanine.dtbo
  • monaco-evk-camera-imx577.dtbo
  • monaco-evk-ifp-mezzanine.dtbo
  • talos-el2.dtbo
  • qcs6490-rb3gen2-industrial-mezzanine.dtbo
  • qcs6490-rb3gen2-vision-mezzanine.dtbo
  • monaco-el2.dtbo
  • lemans-el2.dtbo
  • qrb5165-rb5-vision-mezzanine.dtbo
  • sc7180-el2.dtbo
  • sc8280xp-el2.dtbo
  • sdm845-db845c-navigation-mezzanine.dtbo
  • sm8650-hdk-display-card.dtbo
  • talos-evk-lvds-auo,g133han01.dtbo
  • x1-el2.dtbo

Commit 2/2: BACKPORT: QCLINUX: arm64: dts: qcom: Install camx DTBO overlays

Upstream commit: N/A (vendor-only)
Cherry-picked from: abfeee7

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit
Body preserves rationale Clear explanation of camx DTBO install requirement
Fixes tag present/correct N/A No Fixes tag (not a bugfix)
Authorship preserved Vishwas Udupa vudupa@qti.qualcomm.com consistent
Backport note (if applicable) Cherry-pick note present with source SHA

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds 10 camx DTBO install targets; pattern consistent

DTBO files added (10):

  • hamoa-evk-camx.dtbo
  • lemans-evk-camx.dtbo
  • lemans-camx-el2.dtbo
  • monaco-evk-camx.dtbo
  • monaco-camx-el2.dtbo
  • qcs615-ride-camx.dtbo
  • qcs6490-rb3gen2-vision-mezzanine-camx.dtbo
  • qcs8300-ride-camx.dtbo
  • sa8775p-ride-camx.dtbo
  • talos-evk-camx.dtbo

Issues

Commit 1 - Timeline Anomaly:

  • ⚠️ Commit date vs. lore link date mismatch: Commit authored on Fri, 3 Apr 2026 02:17:06 -0700, but lore message-ID indicates posting date of 2026-04-28 12:37:25. This suggests the commit was created ~25 days BEFORE the patch was posted to the mailing list.
  • Impact: This is unusual but not necessarily incorrect. Possible explanations:
    1. Patch was developed internally first, then posted upstream later
    2. Commit date was preserved from an earlier internal version
    3. The cherry-pick source (7998dbf) may have the earlier date
  • Recommendation: Verify the timeline with the author if this matters for tracking purposes.

Network Restriction:

  • ⚠️ Cannot fetch upstream patch from lore.kernel.org to perform byte-for-byte diff comparison due to network restrictions in this environment.
  • Cannot verify upstream acceptance status (merged/pending/rejected).

Verdict

Commit 1 (FROMLIST): Structurally correct with proper BACKPORT: FROMLIST: prefix, Link tag, Signed-off-by, and cherry-pick note. Diff pattern is clean and consistent. Timeline anomaly noted but not blocking. Cannot verify faithfulness to upstream due to network restrictions.

Commit 2 (QCLINUX): Correct vendor-only format with BACKPORT: QCLINUX: prefix, no Link tag (as expected), proper Signed-off-by and cherry-pick note. Diff pattern is clean and extends Commit 1's work to camx-specific overlays.

Overall: Both commits follow proper kernel commit message conventions and backport tagging. Diffs are surgical, focused, and follow consistent patterns. Merge recommended with the caveat that upstream faithfulness of Commit 1 should be verified when network access is available.


Final Summary

Commit 1/2 (FROMLIST):

  1. Lore link present: Yes — https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com
  2. Lore link matches PR commits: Cannot verify — lore.kernel.org unreachable due to network restrictions
  3. Upstream patch status: Cannot verify — network restricted; FROMLIST prefix indicates patch posted but not yet merged at time of backport
  4. PR present in qcom-next: Not checked — would require kernel tree access (explicitly prohibited in constraints)

Commit 2/2 (QCLINUX):

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis
Copy link
Copy Markdown

PR #654 — checker-log-analyzer

PR: #654
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26945595479

Checker Result Summary
Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check ⏭️ Skipped - no DTBs built
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance 2 compliance violations
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable (BACKPORT commits)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #654 - arm64: dts: qcom: install DT overlays via dtbs_install
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26945595479

Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check ⏭️ Skipped - no DTBs built
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance 2 compliance violations
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable (BACKPORT commits)

❌ check-patch-compliance

Root cause: Patch compliance checker detected two violations in the commit messages.

Failure details:

Commit 1 (3397b96fc7da):

Checking commit: BACKPORT: FROMLIST: arm64: dts: qcom: install DT overlays via dtbs_install
Change is different from the one mentioned in Link

Commit 2 (aaa651a84027):

Checking commit: BACKPORT: QCLINUX: arm64: dts: qcom: Install camx DTBO overlays
No 'Link' found in commit message

Analysis:

  1. First commit issue: The patch claims to be a BACKPORT: FROMLIST: from the lore link https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com, but the checker detected that the actual changes in the PR differ from what's at that upstream link. This violates the backport integrity requirement - a BACKPORT/FROMLIST commit must match the upstream patch exactly (or document intentional deviations).

  2. Second commit issue: The commit is tagged as BACKPORT: QCLINUX: but lacks a Link: trailer entirely. QCLINUX patches should reference the internal commit they're backporting from, or if this is original work, the prefix should be different (e.g., just QCLINUX: without BACKPORT:).

Fix:

For commit 1:

  • If the patch truly matches the FROMLIST version, verify the lore link is correct and the checker may have a false positive
  • If changes were intentionally modified during backport, document the delta in the commit message (e.g., "[ Upstream commit abc123 with modifications: ... ]")
  • If this is actually a different patch, update the Link: to point to the correct upstream source

For commit 2:

  • Add a Link: trailer pointing to the original QCLINUX commit being backported (format: Link: <internal-commit-url> or (cherry picked from commit <sha>))
  • OR if this is new work (not a backport), remove the BACKPORT: prefix and use just QCLINUX: instead

Reproduce locally:

cd /path/to/kernel
git fetch origin pull/654/head:pr-654
git checkout pr-654
../kernel-checkers/check-patch-compliance.sh --kernel-src . --base <base-sha> --head aaa651a84027b82053e4bcec0081dc33decb3359

Verdict

2 blockers must be fixed before merge: Both commits violate patch compliance rules. The first commit's changes don't match its claimed upstream source, and the second commit is missing required Link metadata for a BACKPORT-tagged commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants