pending: arm64: dts: enable iris driver for hamoa kvm

[renjiang-qti]

Add video firmware node to enable video kvm on the hamoa.

The community recommends implementing KVM support using the iommu-map approach. However, the device creation model based on iris_vpu_bus is still under discussion.
Temporarily keep using the video-firmware node approach in the Iris driver to enable KVM support. This change is intended as a stopgap.
Once the community patches are merged, or the iris_vpu_bus-based device creation is finalized, this will be reverted and replaced with the community-recommended approach.

https://jira-dc.qualcomm.com/jira/browse/QLIJIRA-109
CRs-Fixed: 4559873

[qswat-orbit-external]

Merge Check Failed: CR Not Eligible for Merge

CR 4559873 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4559873
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

[qlijarvis]

PR #653 — validate-patch

PR: #653

Verdict	Issues	Detailed Report
⚠️	4	Full report

Final Summary

1. Lore link present: No — "pending:" prefix indicates vendor-only/WIP patch; no lore link expected at this stage
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Not upstream — "pending:" prefix explicitly marks this as pre-upstream work
4. PR present in qcom-next: Not checked — vendor-only commit with "pending:" prefix

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #653 - pending: arm64: dts: enable iris driver for hamoa kvm
Upstream commit: N/A
Verdict: ⚠️ PARTIAL

Commit Message

Check	Status	Note
Subject matches upstream	N/A	"pending:" prefix indicates vendor-only/WIP patch
Body preserves rationale	⚠️	Minimal description; lacks technical detail about IOMMU configuration
Fixes tag present/correct	N/A	Not a fix; new feature enablement
Authorship preserved	✅	Author and SOB present and consistent
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/x1-el2.dtso	✅	Clean change: removes TODO, enables iris, adds video-firmware IOMMU

Issues

• Commit message lacks detail: The body only states "Add video firmware node to enable video kvm on the hamoa" but doesn't explain:
  • Why IOMMU 0x1942 is the correct stream ID for video-firmware
  • What testing was performed to verify this works
  • Whether this depends on other patches or firmware versions
• "pending:" prefix: Indicates this is not ready for upstream submission; should be removed before upstreaming
• Typo in commit body: "hamoa" should be capitalized as "Hamoa" (proper noun for platform name)
• Missing Link tag: No reference to any mailing list discussion or related patches

Verdict

Acceptable for vendor tree integration but needs significant commit message improvement before upstream submission.

Final Summary

1. Lore link present: No — "pending:" prefix indicates vendor-only/WIP patch; no lore link expected at this stage
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Not upstream — "pending:" prefix explicitly marks this as pre-upstream work
4. PR present in qcom-next: Not checked — vendor-only commit with "pending:" prefix

[qlijarvis]

PR #653 — checker-log-analyzer

PR: #653
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26941706022

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	❌	Missing required iommus property on iris node
sparse-check	⏭️	Skipped (no C code changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Subject prefix violation: "pending:" not allowed
tag-check	N/A	Not applicable for qcom-6.18.y
qcom-next-check	N/A	Not applicable for qcom-6.18.y

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #653 - pending: arm64: dts: enable iris driver for hamoa kvm
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26941706022

Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	❌	Missing required iommus property on iris node
sparse-check	⏭️	Skipped (no C code changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Subject prefix violation: "pending:" not allowed
tag-check	N/A	Not applicable for qcom-6.18.y
qcom-next-check	N/A	Not applicable for qcom-6.18.y

---

❌ dtb-check

Root cause: The patch adds a video-firmware child node with iommus property, but the parent &iris node itself is missing the required iommus property per the qcom,x1e80100-iris binding.

Failure details:

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/hamoa-iot-evk-el2.dtb: 
video-codec@aa00000 (qcom,x1e80100-iris): 'iommus' is a required property

Fix: Add the iommus property to the &iris node itself (not just to video-firmware). The iris video codec node requires its own IOMMU mapping. Check the binding documentation at Documentation/devicetree/bindings/media/qcom,*-iris.yaml or reference other X1E80100 DTS files for the correct IOMMU stream ID.

Example fix in arch/arm64/boot/dts/qcom/x1-el2.dtso:

 &iris {
 	status = "okay";
+	iommus = <&apps_smmu 0x21a0 0x0>;
 	video-firmware {
 		iommus = <&apps_smmu 0x1942 0x0>;
 	};
 };

Reproduce locally:

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- dtbs W=1 2>&1 | grep -i "iommus.*required"

---

❌ check-patch-compliance

Root cause: Commit subject starts with pending: prefix, which is not an allowed prefix for qcom-6.18.y branch.

Failure details:

Checking commit: pending: arm64: dts: enable iris driver for hamoa kvm
Commit summary does not start with a required prefix

Fix: Remove the pending: prefix. For device tree changes targeting qcom-6.18.y, the subject should follow standard kernel conventions without special prefixes. The commit subject should be:

arm64: dts: qcom: x1-el2: enable iris driver for hamoa kvm

Or more specifically:

arm64: dts: qcom: x1e80100: enable iris video codec on EL2

Reproduce locally:

git log --oneline -1
# Check that subject doesn't start with "pending:"

---

Verdict

2 blockers must be fixed before merge:

1. Add required iommus property to the &iris node (dtb-check failure)
2. Remove pending: prefix from commit subject (check-patch-compliance failure)