Add qref and refgen regulator support for QCS8300 and SA8775p PCIe PHYs - #1684
Conversation
🔨 Build Failure Analysis — PR #1684PR: #1684
VerdictAll 4 failures are merge conflicts during integration, not compilation errors. None are introduced by this PR's code changes. 📎 Detailed analysis: Full report |
🔨 Build Failure Analysis — PR #1684PR: #1684
VerdictAll 4 failures are merge conflicts, not compilation errors. These are pre-existing conflicts between the PR and the integration branch baseline (topic/tech/bus/pci/all merged into commit 49dbe0dae5cf). The PR code itself is valid. 📎 Detailed analysis: Full report |
…en and refgen supply properties QCS8300 and SA8775p PCIe PHYs require dedicated vdda-refgen and refgen LDO supplies for QREF to provide a stable reference clock. Without these supplies, the PCIe PHYs cannot work properly. Mark them as required for the affected compatibles even though it breaks ABI. vdda-refgen-supply is required for all three QCS8300 and SA8775p PHY compatibles. refgen-supply is required for QCS8300 only, as a workaround for a hardware issue where QREF actually depends on refgen3 rather than refgen2 as documented, so the PHY driver votes for refgen3 directly via this supply. Link: https://lore.kernel.org/r/20260810112735.1326807-2-ziyue.zhang@oss.qualcomm.com Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com>
… QCS8300 and SA8775p PHY Add a new sa8775p_qmp_phy_vreg_l that includes vdda-phy, vdda-pll, vdda-qref, vdda-refgen and refgen supplies, and use it for QCS8300 and SA8775p PCIe PHY configurations. This avoids modifying sm8550_qmp_phy_vreg_l and breaking SM8550 and SM8650. Note that due to a hardware issue, QREF actually depends on refgen3 rather than refgen2 as documented; refgen3 is therefore voted manually via the refgen supply as a workaround. Fixes: a05b6d5 ("phy: qcom-qmp-pcie: add support for sa8775p") Fixes: ebf198f ("phy: qcom-qmp-pcie: add dual lane PHY support for QCS8300") Link: https://lore.kernel.org/r/20260810112735.1326807-3-ziyue.zhang@oss.qualcomm.com Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com>
…CIe PHYs The QMP PCIe PHYs on QCS8300 require dedicated qref and refgen voltage supplies for stable operation. Without these supplies, the system may occasionally crash. Add vdda-qref-supply and vdda-refgen-supply in the board files (QCS8300-RIDE, Monaco-EVK and Monaco-Monza-SoM), and add refgen-supply in the SoC DTSI (monaco.dtsi) since refgen is an on-chip regulator shared across boards. The PHY driver votes for refgen3 directly as a workaround for a hardware issue where QREF actually depends on refgen3 rather than refgen2 as documented. Fixes: 33967ea ("arm64: dts: qcom: qcs8300-ride: enable pcie0 interface") Fixes: cdb613a ("arm64: dts: qcom: qcs8300-ride: enable pcie1 interface") Fixes: 41e2424 ("arm64: dts: qcom: monaco-evk: Enable PCIe0 and PCIe1.") Fixes: 5238f4e ("arm64: dts: qcom: Add Monaco Monza SoM") Link: https://lore.kernel.org/r/20260810112735.1326807-4-ziyue.zhang@oss.qualcomm.com Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com>
…CIe PHYs The QMP PCIe PHYs on SA8775p require dedicated qref and refgen voltage supplies for stable operation. Without these supplies, the system may occasionally crash. Add vdda-qref-supply and vdda-refgen-supply in the board files (Lemans-EVK, Lemans-RIDE, QCS9100-RIDE and QCS9100-RIDE-R3). Fixes: 94d7d37 ("arm64: dts: qcom: lemans-evk: Enable PCIe support") Fixes: 76326da ("arm64: dts: qcom: lemans: Refactor ride/ride-r3 boards based on daughter cards") Link: https://lore.kernel.org/r/20260810112735.1326807-5-ziyue.zhang@oss.qualcomm.com Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com>
843c4ef to
c02816d
Compare
PR #1684 — validate-patchPR: #1684
Final Summary
|
PR #1684 — checker-log-analyzerPR: #1684
Detailed report: Full report
|
🔨 Build Failure Analysis — PR #1684PR: #1684
VerdictNo compilation errors found. The build failed during the merge phase due to 4 merge conflicts between this PR and the integration branch. These conflicts are not caused by errors in the PR code itself, but by overlapping changes in the same files between the PR and the target branch. 📎 Detailed analysis: Full report |
🔨 Build Failure Analysis — PR #1684PR: #1684
VerdictAll 4 merge conflicts are introduced by this PR when merging into the integration branch. The build never reached compilation - it failed during the merge phase. 📎 Detailed analysis: Full report |
PR #1684 — validate-patchPR: #1684
Final Summary
|
PR #1684 — checker-log-analyzerPR: #1684
Detailed report: Full report
|
This series adds qref and refgen regulator support for the PCIe QMP PHYs on QCS8300 and SA8775p platforms.
The PCIe PHYs on these SoCs require dedicated qref and refgen voltage supplies for stable operation. Without enabling these supplies, PCIe may be unstable and the system can occasionally crash under certain scenarios.
The refgen supply in particular works around a hardware issue where both QREF and the PCIe PHY are expected to depend on refgen2, but QREF actually depends on refgen3. This series therefore votes for refgen3 manually via the refgen supply.
Change 1: dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Add vdda-refgen and refgen supply properties
Change 2: phy: qcom: qmp-pcie: Add qref and refgen regulator vote for QCS8300 and SA8775p PHY
Change 3: arm64: dts: qcom: qcs8300: Add qref and refgen supply for PCIe PHYs
Change 4: arm64: dts: qcom: sa8775p: Add qref and refgen supply for PCIe PHYs
Link: https://lore.kernel.org/r/20260810112735.1326807-1-ziyue.zhang@oss.qualcomm.com