QCLINUX: memory-dump: add SPR/cache dump entries for Hamoa and Glymur

[Jie Gan (jiegan0107)]

add SPR/cache dump entries for Hamoa and Glymur

[qlijarvis]

PR #1683 — validate-patch

PR: #1683

Verdict	Issues	Detailed Report
⚠️	1	Full report

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only changes, not posted upstream
4. PR present in qcom-next/topics: Fail - 3/3 commit(s) are missing from both qcom-next and topics

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1683 - QCLINUX: memory-dump: extend SPR CPU dump range and add entries for Hamoa/Glymur
Upstream commit: N/A (vendor-only changes)
Verdict: ⚠️ PARTIAL

Commit 1/3: QCLINUX: memory-dump: extend SPR CPU dump range to CPU11

Commit Message

Check	Status	Note
Subject matches upstream	N/A	QCLINUX: vendor-only commit
Body preserves rationale	✅	Clear description of change
Fixes tag present/correct	N/A	Not a fix
Authorship preserved	✅	Jie Gan jie.gan@oss.qualcomm.com
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
drivers/firmware/qcom/memory_dump_v2.c	✅	Extends SPR_DUMP range from CPU7 to CPU11; removes redundant macros

Commit 2/3: QCLINUX: memory-dump: add SPR/cache dump entries for Hamoa

Commit Message

Check	Status	Note
Subject matches upstream	N/A	QCLINUX: vendor-only commit
Body preserves rationale	✅	Clear description of added entries
Fixes tag present/correct	N/A	Not a fix
Authorship preserved	✅	Jie Gan jie.gan@oss.qualcomm.com
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
drivers/firmware/qcom/memory_dump_dev.c	✅	Adds SPR_CPU0-11, CACHE_CPU0-11, CACHE_CLUSTER0-2, C_CONTEXT, CPUSS_REG entries for Hamoa

Commit 3/3: QCLINUX: memory-dump: add SPR/cache dump entries for Glymur

Commit Message

Check	Status	Note
Subject matches upstream	N/A	QCLINUX: vendor-only commit
Body preserves rationale	✅	Clear description of added entries
Fixes tag present/correct	N/A	Not a fix
Authorship preserved	✅	Jie Gan jie.gan@oss.qualcomm.com
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
drivers/firmware/qcom/memory_dump_dev.c	✅	Adds SPR_CPU0-11, CACHE_CPU0-11, CACHE_CLUSTER0-2, C_CONTEXT, CPUSS_REG entries for Glymur

Issues

• Integration presence: All three commits are missing from both qcom-next and topics branches. For vendor-only QCLINUX: commits, this may be expected if they are new additions, but it should be verified that these changes are intentional and not duplicates of existing work.

Verdict

Vendor-only commits with clear commit messages and consistent authorship. The changes extend memory dump coverage for CPU0-CPU11 on Hamoa and Glymur platforms. However, all commits are missing from qcom-next/topics, which should be verified as intentional for new vendor features.

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only changes, not posted upstream
4. PR present in qcom-next/topics: Fail - 3/3 commit(s) are missing from both qcom-next and topics (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 49dbe0dae5cfb7a1eb3434cde6fc7ba37924fe94
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/3	[PATCH 1/3] QCLINUX: memory-dump: extend SPR CPU dump range to CPU11	missing - no subject, patch-id, or full tree-content match found	missing - no subject, patch-id, or full tree-content match found	missing
2/3	[PATCH 2/3] QCLINUX: memory-dump: add SPR/cache dump entries for	missing - no subject, patch-id, or full tree-content match found	missing - no subject, patch-id, or full tree-content match found	missing
3/3	[PATCH 3/3] QCLINUX: memory-dump: add SPR/cache dump entries for	missing - no subject, patch-id, or full tree-content match found	missing - no subject, patch-id, or full tree-content match found	missing

Final Status

overall_status: FAIL
present_commits: 0/3
partial_commits: 0/3
missing_commits: 3/3
topics_checked_for_commits: 3/3
final_summary: PR present in qcom-next/topics: Fail - 3/3 commit(s) are missing from both qcom-next and topics

[qlijarvis]

PR #1683 — checker-log-analyzer

PR: #1683
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31660311785

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	All 3 commits passed
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	⏭️	Skipped (no DTS changes)
sparse-check	✅	Passed
check-uapi-headers	✅	Passed (no UAPI changes)
check-patch-compliance	❌	All 3 commits failed prefix check
tag-check	⚠️	See qcom-next-check below
qcom-next-check	⚠️	QCLINUX: commits without upstream links

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1683 - memory-dump: extend SPR CPU dump range and add entries for Hamoa/Glymur
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/31660311785

Checker	Result	Summary
checkpatch	✅	All 3 commits passed
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	⏭️	Skipped (no DTS changes)
sparse-check	✅	Passed
check-uapi-headers	✅	Passed (no UAPI changes)
check-patch-compliance	❌	All 3 commits failed prefix check
tag-check	⚠️	See qcom-next-check below
qcom-next-check	⚠️	QCLINUX: commits without upstream links

---

❌ check-patch-compliance

Root cause: All three commits use the QCLINUX: prefix, which is not in the allowed list for check-patch-compliance.

Failure details:

Checking commit: QCLINUX: memory-dump: extend SPR CPU dump range to CPU11
Commit summary does not start with a required prefix

Checking commit: QCLINUX: memory-dump: add SPR/cache dump entries for Hamoa
Commit summary does not start with a required prefix

Checking commit: QCLINUX: memory-dump: add SPR/cache dump entries for Glymur
Commit summary does not start with a required prefix

Analysis:

The check-patch-compliance checker enforces that commit subjects start with one of these prefixes:

• FROMLIST: (posted to mailing list)
• FROMGIT: (from maintainer tree)
• UPSTREAM: (merged into mainline)
• BACKPORT: (backported with modifications)

The QCLINUX: prefix is not in this allowed list. According to the skill reference documentation (Section 7, log-patterns.md):

QCLINUX: and PENDING: prefixes always fail check-patch-compliance — this is a known checker limitation for vendor-only commits.

Context:

These are vendor-specific changes to Qualcomm's memory dump infrastructure:

1. Extending SPR CPU dump range from CPU7 to CPU11
2. Adding SPR/cache dump entries for Hamoa platform
3. Adding SPR/cache dump entries for Glymur platform

These changes modify drivers/firmware/qcom/memory_dump_v2.c and drivers/firmware/qcom/memory_dump_dev.c, which are Qualcomm vendor-specific drivers with no upstream equivalent in mainline Linux.

Expected behavior:

This is a known limitation of the check-patch-compliance checker. Vendor-only commits that use QCLINUX: will always fail this check because:

• The checker only accepts upstream-linkable prefixes
• These changes have no upstream equivalent (vendor-specific firmware interface)
• No Link: to lore.kernel.org can be provided

Fix options:

Option 1 (Not recommended): Change prefix to FROMLIST: and add a fake upstream link

• ❌ This would be misleading — these patches were never posted upstream
• ❌ Violates commit message integrity

Option 2 (Recommended): Accept the checker failure as expected

• ✅ This is the documented behavior for QCLINUX: commits
• ✅ The checker limitation is known and accepted for vendor-only work
• ✅ All other checkers passed (checkpatch, sparse, uapi)

Option 3: If these changes could be upstreamed:

• Post the patches to the appropriate mailing list (linux-arm-msm@vger.kernel.org)
• Change prefix to FROMLIST:
• Add Link: trailer pointing to the lore.kernel.org archive

Reproduce locally:

# This will always fail for QCLINUX: commits
cd /path/to/kernel
git log --oneline -3  # shows the three commits
# check-patch-compliance.sh will reject any commit starting with QCLINUX:

---

⚠️ qcom-next-check (FROMLIST:/UPSTREAM: requirement)

Note: I cannot definitively determine the target branch from the available logs. The analysis below applies if and only if the target branch is not qcom-next or qcom-next-staging.

If targeting a branch other than qcom-next/qcom-next-staging:

All commits in this PR use the QCLINUX: prefix, which indicates vendor-only changes. While QCLINUX: is a valid prefix tag (unlike the checker's limitation above), commits targeting most branches should ideally have upstream links when possible.

Commits:

1. 22940b4f6a29 - "QCLINUX: memory-dump: extend SPR CPU dump range to CPU11"
2. a5f78aea73e9 - "QCLINUX: memory-dump: add SPR/cache dump entries for Hamoa"
3. 11af4e60243a - "QCLINUX: memory-dump: add SPR/cache dump entries for Glymur"

Assessment:

These are legitimate vendor-specific changes to Qualcomm firmware interfaces that have no upstream equivalent. The QCLINUX: prefix is appropriate because:

• The memory_dump_v2.c and memory_dump_dev.c drivers are Qualcomm vendor-specific
• The changes add platform-specific dump table entries for Hamoa and Glymur
• No upstream equivalent exists in mainline Linux

If targeting qcom-next or qcom-next-staging:

• ✅ No prefix requirement — these branches accept commits without upstream prefixes
• ✅ QCLINUX: is acceptable

---

Verdict

For check-patch-compliance: This is an expected failure for vendor-only commits. The checker limitation is documented and known. No action required unless the changes can be upstreamed.

Overall recommendation:

✅ Merge as-is if:

• Target branch is qcom-next or qcom-next-staging, OR
• Target branch accepts vendor-only QCLINUX: commits, AND
• The team accepts the known check-patch-compliance limitation

⚠️ Consider upstream submission if:

• These memory dump interfaces could be generalized for upstream
• There's value in upstreaming the SPR/cache dump framework
• Then change prefix to FROMLIST: and add Link: trailers

Technical quality: All code-quality checkers passed (checkpatch, sparse, uapi). The changes are well-formed and follow kernel coding style.