Repository navigation
Fix raffle expiry, draw bounties and staking stream timing - #1
Merged
Merged
Conversation
Apply the reviewed contract patch with regression tests and updated SHA256SUMS. Expired raffle rounds close without a reroll; timely draws earn a 1% bounty. Stake rewards use fixed-end tranches so syncs and dust cannot delay prior income. Document blockhash randomness, small-pot guidance and a future VRF upgrade. Pin forge-std v1.9.7 for reproducible local tests. No deployments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expired raffle draws could be re-armed after a losing hash expired. This closes the round without a winner, carries the pot forward and pays a 1% bounty for a timely completed draw. Staking rewards now use fixed-end tranches so later syncs or dust cannot delay income already streaming.
Keeps the reviewed
builder-kit-fix.patchproduction contracts and SHA256SUMS exact. Its nine regression tests are included, with the JIT fixture corrected to select the actual next epoch boundary and assert the intended 24-hour-plus-one-minute stream window. The README explains blockhash randomness, small-pot limits and the future VRF upgrade. A pinned forge-std v1.9.7 submodule makes the new tests reproducible from a fresh clone. QModuleBase, SDK and CI workflow remain unchanged.Validation:
cd contracts && forge test --offline --threads 2 -vv: 9/9 pass, including 256 conservation fuzz runs (Solc 0.8.26).No deployment, RPC/fork, key, wallet or funds action. The separately patched QStakeVault is handed to the next launch-factory generation backlog; it is not bundled into this public-module change.