Skip to content

build(cli): read release app credentials in the version job - #1529

Merged
Chase J (chajac) merged 1 commit into
mainfrom
version-job-environment
Aug 27, 2026
Merged

build(cli): read release app credentials in the version job#1529
Chase J (chajac) merged 1 commit into
mainfrom
version-job-environment

Conversation

@chajac

@chajac Chase J (chajac) commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Note

PR body AI drafted & edited as needed

Overview of Changes

#1524 moved the deployment approval onto the publish job, so version runs without an environment. So a required key is empty in version and create-github-app-token fails with "The 'client-id' (or deprecated 'app-id') input must be set to a non-empty string" error.

  • .github/workflows/release.yml: puts the version job on a release-version environment.

Testing

actionlint .github/workflows/release.yml
bun run lint --max-warnings 0
bun run format:check
bun run typecheck
bun run knip

Checklist

  • Changes follow the code style of this project
  • Self-review completed
  • Tests added/updated (or not applicable)
  • No breaking changes (or described below)

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 61067775-9cee-47fb-b9f6-82b810628eb0

📥 Commits

Reviewing files that changed from the base of the PR and between 17ae037 and 914af8e.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.


Walkthrough

The Version PR job in .github/workflows/release.yml now declares the release-version environment. This changes the job’s credential and environment-protection context.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 914af

This localized workflow change assigns the version job to the release-version environment so required release credentials are available; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: mateuszitelli, michael-pr

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows Conventional Commits with the allowed type and scope. It uses imperative mood, describes the credential change in the version job, stays under 72 characters, and has no trailing punc…
Description check ✅ Passed The description includes an overview, concrete testing commands, and a completed checklist. It explains why the release-version environment is required and identifies the affected workflow file.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title follows Conventional Commits with the allowed type and scope. It uses imperative mood, describes the credential change in the version job, stays under 72 characters, and has no trailing punctuation.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch version-job-environment

Comment @coderabbitai help to get the list of available commands.

@chajac
Chase J (chajac) marked this pull request as ready for review August 27, 2026 10:17
@chajac
Chase J (chajac) merged commit 2d54a31 into main Aug 27, 2026
7 checks passed
@chajac
Chase J (chajac) deleted the version-job-environment branch August 27, 2026 20:23
This was referenced Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants