Skip to content

[executorch][vulkan] Make the et_vk.rms_norm weight optional - #25096

Open
digantdesai wants to merge 1 commit into
gh/digantdesai/212/basefrom
gh/digantdesai/212/head
Open

digantdesai wants to merge 1 commit into
gh/digantdesai/212/basefrom
gh/digantdesai/212/head

Conversation

@digantdesai

@digantdesai digantdesai commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

aten.rms_norm takes an optional weight, but et_vk.rms_norm required one, so ET-VK had no kernel for a norm without an elementwise affine. The schema now takes Tensor? weight, and its eager reference skips the multiply for a None weight. When the weight is None, add_rms_norm_node skips the weight prepack, binds only the input, and dispatches the new rms_norm_no_weight texture and buffer variants. The HAS_WEIGHT shader parameter defaults to false, which compiles out the weight binding and multiply, and the weighted variants set it, so they keep their names and their math.

The WebGPU rms_norm kernel always binds a weight, so the WebGPU partitioner leaves an et_vk.rms_norm with a None weight on CPU.

Authored with Claude Code.

Differential Revision: D131119349

NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!

[ghstack-poisoned]
@digantdesai
digantdesai requested a review from SS-JIA as a code owner November 14, 2026 19:29
@pytorch-bot pytorch-bot Bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Nov 14, 2026
@pytorch-bot

pytorch-bot Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/25096

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 3568c3c with merge base 925c1bd (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This branch was previously deployed

1 inactive deployment
cadence — 3568c3cb Deployed Nov 14, 2026 by digantdesai via hifi-op-test / hifi4 #38411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant