Repository navigation
[executorch][vulkan] Make the et_vk.rms_norm weight optional - #25096
Open
digantdesai wants to merge 1 commit into
Open
digantdesai wants to merge 1 commit into
digantdesai wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/25096
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 3568c3c with merge base 925c1bd ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
aten.rms_normtakes an optional weight, butet_vk.rms_normrequired one, so ET-VK had no kernel for a norm without an elementwise affine. The schema now takesTensor? weight, and its eager reference skips the multiply for a None weight. When the weight is None,add_rms_norm_nodeskips the weight prepack, binds only the input, and dispatches the newrms_norm_no_weighttexture and buffer variants. TheHAS_WEIGHTshader parameter defaults to false, which compiles out the weight binding and multiply, and the weighted variants set it, so they keep their names and their math.The WebGPU rms_norm kernel always binds a weight, so the WebGPU partitioner leaves an
et_vk.rms_normwith a None weight on CPU.Authored with Claude Code.
Differential Revision: D131119349
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!