Skip to content

Serve one batching session from a single-sequence cache - #24953

Closed
metascroy wants to merge 1 commit into
offgraph-kv-sequence-lengthfrom
offgraph-kv-sequence-batch-control
Closed

metascroy wants to merge 1 commit into
offgraph-kv-sequence-lengthfrom
offgraph-kv-sequence-batch-control

Conversation

@metascroy

@metascroy metascroy commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Stack

Off-graph KV cache for the native ggml engine, through serving Muse Glimmer on it. Review bottom-up; each PR builds and passes its tests on its own.

Summary

SessionTable maps sessions to cache sequences through BatchControl, which only multi-sequence caches offer. So an executor over a single-sequence cache had to reimplement packing, rewinds and sampling. SequenceBatchControl (extension/llm/batching/util) gives such a cache the BatchControl face with one sequence:

  • seq_new claims it; seq_rm clears and frees it.
  • rewind and pos go to SequenceControl.
  • clone is refused.

A SessionTable over it serves one session at a time.

Test plan

session_table_test.cpp: one session at a time, abutting chunks, rewinding into committed history, refused clones, and close/reopen starting empty.


Authored with Claude Code.

SessionTable maps sessions to cache sequences through BatchControl, which
only multi-sequence caches offer, so an executor over a single-sequence
cache had to reimplement packing, rewinds and sampling. SequenceBatchControl
gives such a cache the BatchControl face with one sequence: seq_new claims
it, seq_rm clears and frees it, rewind and pos go to SequenceControl, and
clone is refused. A SessionTable over it serves one session at a time.
@pytorch-bot

pytorch-bot Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24953

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 164 New Failures, 6 Unrelated Failures, 23 Unclassified Failures

As of commit 703d73e with merge base c7f7931 (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2026
@metascroy

Copy link
Copy Markdown
Contributor Author

Superseded: the native executor now serves sessions from a real multi-sequence ggml cache (#25007) instead of adapting the single-sequence cache, so this is no longer needed.

@metascroy metascroy closed this Nov 13, 2026
@metascroy
metascroy deleted the offgraph-kv-sequence-batch-control branch November 13, 2026 00:58

This branch had an error being deployed

1 failed deployment
cadence — 703d73ee Deployed Nov 12, 2026 by metascroy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant