Repository navigation
Conversation
SessionTable maps sessions to cache sequences through BatchControl, which only multi-sequence caches offer, so an executor over a single-sequence cache had to reimplement packing, rewinds and sampling. SequenceBatchControl gives such a cache the BatchControl face with one sequence: seq_new claims it, seq_rm clears and frees it, rewind and pos go to SequenceControl, and clone is refused. A SessionTable over it serves one session at a time.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24953
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 164 New Failures, 6 Unrelated Failures, 23 Unclassified FailuresAs of commit 703d73e with merge base c7f7931 ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 12, 2026
Contributor
Author
|
Superseded: the native executor now serves sessions from a real multi-sequence ggml cache (#25007) instead of adapting the single-sequence cache, so this is no longer needed. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Off-graph KV cache for the native ggml engine, through serving Muse Glimmer on it. Review bottom-up; each PR builds and passes its tests on its own.
Summary
SessionTablemaps sessions to cache sequences throughBatchControl, which only multi-sequence caches offer. So an executor over a single-sequence cache had to reimplement packing, rewinds and sampling.SequenceBatchControl(extension/llm/batching/util) gives such a cache theBatchControlface with one sequence:seq_newclaims it;seq_rmclears and frees it.rewindandposgo toSequenceControl.cloneis refused.A
SessionTableover it serves one session at a time.Test plan
session_table_test.cpp: one session at a time, abutting chunks, rewinding into committed history, refused clones, and close/reopen starting empty.Authored with Claude Code.