Skip to content

Fold redundant DQ - > Q (#21016)#21016

Open
JakeStevens wants to merge 1 commit into
pytorch:mainfrom
JakeStevens:export-D112564036
Open

Fold redundant DQ - > Q (#21016)#21016
JakeStevens wants to merge 1 commit into
pytorch:mainfrom
JakeStevens:export-D112564036

Conversation

@JakeStevens

@JakeStevens JakeStevens commented Jul 17, 2026 •
edited by meta-codesync Bot
Loading

Copy link
Copy Markdown
Contributor

Summary:

remove_decompositions({}) can remove certain no-ops like dropout, but this occurs after annotation. So, this leaves a redudant DQ->Q in the graph, which introduces Neutron graph breaks.

This PR removes these subchains, allowing for full delegation i nthese instances.

Reviewed By: rascani

Differential Revision: D112564036

@pytorch-bot

pytorch-bot Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21016

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 48a4947 with merge base 8077bb6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2026
@meta-codesync

meta-codesync Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112564036.

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@JakeStevens @facebook-github-bot
Fold redundant DQ - > Q (pytorch#21016)
48a4947 
Summary:

remove_decompositions({}) can remove certain no-ops like dropout, but this occurs after annotation. So, this leaves a redudant DQ->Q in the graph, which introduces Neutron graph breaks.

This PR removes these subchains, allowing for full delegation i nthese instances.

Reviewed By: rascani

Differential Revision: D112564036
@meta-codesync meta-codesync Bot changed the title Fold redundant DQ - > Q Fold redundant DQ - > Q (#21016) Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rascani rascani rascani approved these changes
@robert-kalmar robert-kalmar Awaiting requested review from robert-kalmar robert-kalmar is a code owner
@novak-vaclav novak-vaclav Awaiting requested review from novak-vaclav
@MartinPavella MartinPavella Awaiting requested review from MartinPavella

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JakeStevens @rascani