Skip to content

fix(tests): compare baddbmm lowering against TensorRT in fp32, not TF32 #4586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shoumikhin wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

fix(tests): compare baddbmm lowering against TensorRT in fp32, not TF32 #4586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/py/dynamo/lowering/test_decompositions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2507,6 +2507,10 @@ def forward(self, bias, batch1, batch2):
inputs,
min_block_size=1,
pass_through_build_failures=True,
# The reference below runs the matmul in full fp32, so TensorRT has to
# as well. TF32 is on by default and rounds the operands to 10 mantissa
# bits, which costs far more than DECIMALS_OF_AGREEMENT allows.
disable_tf32=True,
)
with torch.no_grad():
trt_results = optimized_model(*inputs).detach().cpu()
Expand Down
Loading