Skip to content

fix(dynamo): stop unpacking complex inputs before the refit output check #4583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shoumikhin wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −32
Open

fix(dynamo): stop unpacking complex inputs before the refit output check #4583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ac0da6
fix(dynamo): stop unpacking complex inputs before the refit output check
Aug 26, 2026
3df88ae
style: format test_cumsum_aten.py with black
shoumikhin Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 8 additions & 25 deletions py/torch_tensorrt/dynamo/_refit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
from torch_tensorrt.dynamo.runtime._TRTEngine import TRTEngine
from torch_tensorrt.dynamo.utils import (
check_module_output,
check_output_equal,
get_torch_inputs,
to_torch_device,
to_torch_tensorrt_device,
Expand Down Expand Up @@ -436,31 +435,15 @@ def refit_module_weights(

if verify_output and arg_inputs is not None:
new_gm.to(to_torch_device(settings.device)) # move to device for inference
# complex_graph_detection rewrites complex placeholders to real (view_as_real).
# The compiled TRT module handles complex→real internally, but the lowered
# PyTorch reference module (new_gm) expects real-unpacked inputs directly.
has_complex_inputs = any(
isinstance(x, torch.Tensor) and x.is_complex() for x in torch_inputs
# A complex placeholder stays complex in the lowered reference module; the
# unpacking to real happens inside the graph, so both modules take the same
# inputs the caller passed.
outputs_match = check_module_output(
new_module=new_gm,
refitted_module=compiled_module,
arg_inputs=torch_inputs,
kwarg_inputs=torch_kwarg_inputs,
)
if has_complex_inputs:
lowered_inputs = [
(
torch.view_as_real(x).contiguous()
if isinstance(x, torch.Tensor) and x.is_complex()
else x
)
for x in torch_inputs
]
trt_outputs = compiled_module(*torch_inputs)
ref_outputs = new_gm(*lowered_inputs, **torch_kwarg_inputs)
outputs_match = check_output_equal(trt_outputs, ref_outputs)
else:
outputs_match = check_module_output(
new_module=new_gm,
refitted_module=compiled_module,
arg_inputs=torch_inputs,
kwarg_inputs=torch_kwarg_inputs,
)
if outputs_match:
logger.info("Refitting Succeed!")
else:
Expand Down
9 changes: 2 additions & 7 deletions tests/py/dynamo/conversion/test_cumsum_aten.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@ def forward(self, x):
)
return

self.run_test(
Cumsum(), inputs, immutable_weights=False, use_dynamo_tracer=True
)
self.run_test(Cumsum(), inputs, immutable_weights=False, use_dynamo_tracer=True)

@parameterized.expand(
[
Expand Down Expand Up @@ -108,10 +106,7 @@ def forward(self, x):
== opt_shape[positive_dim]
== max_shape[positive_dim]
)
if (
has_static_trip_count
and not is_tensorrt_rtx_version_supported("1.7")
):
if has_static_trip_count and not is_tensorrt_rtx_version_supported("1.7"):
with self.assertRaises(UnsupportedOperatorException):
self.run_test_with_dynamic_shape(
Cumsum(),
Expand Down
Loading