Skip to content

Solved serialization error with stale torch version#4361

Open
cehongwang wants to merge 23 commits into
release/ngc/26.07from
cehongw/serialization-patch
Open

Solved serialization error with stale torch version#4361
cehongwang wants to merge 23 commits into
release/ngc/26.07from
cehongw/serialization-patch

Conversation

@cehongwang

Copy link
Copy Markdown
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

tp5uiuc and others added 11 commits June 16, 2026 10:36
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
Co-authored-by: Naren Dasan <1790613+narendasan@users.noreply.github.com>
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
@cehongwang cehongwang requested a review from apbose June 23, 2026 21:37
@meta-cla meta-cla Bot added the cla signed label Jun 23, 2026
@cehongwang cehongwang requested a review from narendasan June 23, 2026 21:37
@github-actions github-actions Bot added the component: api [Python] Issues re: Python API label Jun 23, 2026
@github-actions github-actions Bot requested a review from zewenli98 June 23, 2026 21:37
jloftin-nv and others added 4 commits June 24, 2026 12:35
@apbose

apbose commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

tests/py/dynamo/models/test_cross_runtime_serde.py still fails (all 3: test_save_cpp_load_python, test_save_python_load_python, test_save_python_load_cpp) on every platform where it runs .
PytorchStreamReader failed locating file constants.pkl: file not found failed while attempting to run meta for aten.set_.source_Storage. For python only path the engine still remains an opaque object. Should we disable these tests for the stale torch version?

@cehongwang cehongwang force-pushed the cehongw/serialization-patch branch from 5b48822 to 8aa10ca Compare June 29, 2026 20:29
@github-actions github-actions Bot added documentation Improvements or additions to documentation component: tests Issues re: Tests component: lowering Issues re: The lowering / preprocessing passes component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: converters Issues re: Specific op converters component: build system Issues re: Build system component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: runtime component: tests Issues re: Tests documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants