Skip to content

Add tests for Final/Literal interaction #2352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srittau wants to merge 7 commits into from
Closed

Add tests for Final/Literal interaction #2352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d52de49
Add tests for `Final`/`Literal` interaction
srittau Aug 31, 2026
4276314
Fix type assertions
srittau Aug 31, 2026
b214de4
Reshuffle, fix, comment
srittau Aug 31, 2026
c61cb1c
Finagle tests more
srittau Aug 31, 2026
d42d2fd
Update results
srittau Aug 31, 2026
5b3a1bb
One case is optional per the spec, add another case
srittau Aug 31, 2026
ae58134
Update results
srittau Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 40 additions & 38 deletions conformance/results/mypy/qualifiers_final_annotation.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,45 +6,47 @@ Does not allow redefinition of private class variable that is marked `Final` in
Does not report modification of local `Final` variable via `for` statement.
"""
output = """
qualifiers_final_annotation.py:16: error: Type in Final[...] can only be omitted if there is an initializer [misc]
qualifiers_final_annotation.py:18: error: Final[...] takes at most one type argument [misc]
qualifiers_final_annotation.py:34: error: Type in Final[...] can only be omitted if there is an initializer [misc]
qualifiers_final_annotation.py:38: error: Final name must be initialized with a value [misc]
qualifiers_final_annotation.py:54: error: Cannot assign to final attribute "ID5" [misc]
qualifiers_final_annotation.py:59: error: Cannot assign to final attribute "ID6" [misc]
qualifiers_final_annotation.py:62: error: Can only declare a final attribute in class body or __init__ [misc]
qualifiers_final_annotation.py:63: error: Can only declare a final attribute in class body or __init__ [misc]
qualifiers_final_annotation.py:65: error: Cannot assign to final attribute "ID7" [misc]
qualifiers_final_annotation.py:67: error: Cannot assign to final attribute "ID7" [misc]
qualifiers_final_annotation.py:71: error: Cannot assign to final name "RATE" [misc]
qualifiers_final_annotation.py:81: error: Cannot assign to final attribute "DEFAULT_ID" [misc]
qualifiers_final_annotation.py:94: error: Cannot assign to final name "BORDER_WIDTH" [misc]
qualifiers_final_annotation.py:96: error: Cannot assign to final name "__private" [misc]
qualifiers_final_annotation.py:107: error: Final can be only used as an outermost qualifier in a variable annotation [valid-type]
qualifiers_final_annotation.py:108: error: Variable should not be annotated with both ClassVar and Final [misc]
qualifiers_final_annotation.py:118: error: Final can be only used as an outermost qualifier in a variable annotation [valid-type]
qualifiers_final_annotation.py:121: error: Final can be only used as an outermost qualifier in a variable annotation [valid-type]
qualifiers_final_annotation.py:131: error: Final[...] can't be used inside a TypedDict [valid-type]
qualifiers_final_annotation.py:136: error: Final[...] can't be used inside a NamedTuple [valid-type]
qualifiers_final_annotation.py:145: error: Invalid "NamedTuple()" field name [misc]
qualifiers_final_annotation.py:147: error: Unexpected keyword argument "x" for "N" [call-arg]
qualifiers_final_annotation.py:147: error: Unexpected keyword argument "y" for "N" [call-arg]
qualifiers_final_annotation.py:148: error: Unexpected keyword argument "a" for "N" [call-arg]
qualifiers_final_annotation.py:149: error: Unexpected keyword argument "x" for "N" [call-arg]
qualifiers_final_annotation.py:149: error: Unexpected keyword argument "y" for "N" [call-arg]
qualifiers_final_annotation.py:155: error: Cannot assign to final name "ID1" [misc]
qualifiers_final_annotation.py:159: error: Cannot assign to final name "x" [misc]
qualifiers_final_annotation.py:161: error: Cannot assign to final name "x" [misc]
qualifiers_final_annotation.py:166: error: Incompatible types in assignment (expression has type "TextIOWrapper[_WrappedBuffer]", variable has type "int") [assignment]
qualifiers_final_annotation.py:169: error: Cannot assign to final name "x" [misc]
qualifiers_final_annotation.py:180: error: Cannot assign to final name "TEN" [misc]
qualifiers_final_annotation.py:184: error: Cannot assign to final name "PI" [misc]
qualifiers_final_annotation.py:20: error: Argument 1 to "expects_one" has incompatible type "int"; expected "Literal[1]" [arg-type]
qualifiers_final_annotation.py:23: error: Argument 1 to "expects_one" has incompatible type "int"; expected "Literal[1]" [arg-type]
qualifiers_final_annotation.py:32: error: Type in Final[...] can only be omitted if there is an initializer [misc]
qualifiers_final_annotation.py:34: error: Final[...] takes at most one type argument [misc]
qualifiers_final_annotation.py:50: error: Type in Final[...] can only be omitted if there is an initializer [misc]
qualifiers_final_annotation.py:54: error: Final name must be initialized with a value [misc]
qualifiers_final_annotation.py:70: error: Cannot assign to final attribute "ID5" [misc]
qualifiers_final_annotation.py:75: error: Cannot assign to final attribute "ID6" [misc]
qualifiers_final_annotation.py:78: error: Can only declare a final attribute in class body or __init__ [misc]
qualifiers_final_annotation.py:79: error: Can only declare a final attribute in class body or __init__ [misc]
qualifiers_final_annotation.py:81: error: Cannot assign to final attribute "ID7" [misc]
qualifiers_final_annotation.py:83: error: Cannot assign to final attribute "ID7" [misc]
qualifiers_final_annotation.py:87: error: Cannot assign to final name "RATE" [misc]
qualifiers_final_annotation.py:97: error: Cannot assign to final attribute "DEFAULT_ID" [misc]
qualifiers_final_annotation.py:110: error: Cannot assign to final name "BORDER_WIDTH" [misc]
qualifiers_final_annotation.py:112: error: Cannot assign to final name "__private" [misc]
qualifiers_final_annotation.py:123: error: Final can be only used as an outermost qualifier in a variable annotation [valid-type]
qualifiers_final_annotation.py:124: error: Variable should not be annotated with both ClassVar and Final [misc]
qualifiers_final_annotation.py:134: error: Final can be only used as an outermost qualifier in a variable annotation [valid-type]
qualifiers_final_annotation.py:137: error: Final can be only used as an outermost qualifier in a variable annotation [valid-type]
qualifiers_final_annotation.py:147: error: Final[...] can't be used inside a TypedDict [valid-type]
qualifiers_final_annotation.py:152: error: Final[...] can't be used inside a NamedTuple [valid-type]
qualifiers_final_annotation.py:161: error: Invalid "NamedTuple()" field name [misc]
qualifiers_final_annotation.py:163: error: Unexpected keyword argument "x" for "N" [call-arg]
qualifiers_final_annotation.py:163: error: Unexpected keyword argument "y" for "N" [call-arg]
qualifiers_final_annotation.py:164: error: Unexpected keyword argument "a" for "N" [call-arg]
qualifiers_final_annotation.py:165: error: Unexpected keyword argument "x" for "N" [call-arg]
qualifiers_final_annotation.py:165: error: Unexpected keyword argument "y" for "N" [call-arg]
qualifiers_final_annotation.py:171: error: Cannot assign to final name "ID1" [misc]
qualifiers_final_annotation.py:175: error: Cannot assign to final name "x" [misc]
qualifiers_final_annotation.py:177: error: Cannot assign to final name "x" [misc]
qualifiers_final_annotation.py:182: error: Incompatible types in assignment (expression has type "TextIOWrapper[_WrappedBuffer]", variable has type "int") [assignment]
qualifiers_final_annotation.py:185: error: Cannot assign to final name "x" [misc]
qualifiers_final_annotation.py:196: error: Cannot assign to final name "TEN" [misc]
qualifiers_final_annotation.py:200: error: Cannot assign to final name "PI" [misc]
"""
conformance_automated = "Fail"
errors_diff = """
Line 163: Expected 1 errors
Line 59: Unexpected errors ['qualifiers_final_annotation.py:59: error: Cannot assign to final attribute "ID6" [misc]']
Line 96: Unexpected errors ['qualifiers_final_annotation.py:96: error: Cannot assign to final name "__private" [misc]']
Line 145: Unexpected errors ['qualifiers_final_annotation.py:145: error: Invalid "NamedTuple()" field name [misc]']
Line 147: Unexpected errors ['qualifiers_final_annotation.py:147: error: Unexpected keyword argument "x" for "N" [call-arg]', 'qualifiers_final_annotation.py:147: error: Unexpected keyword argument "y" for "N" [call-arg]']
Line 179: Expected 1 errors
Line 75: Unexpected errors ['qualifiers_final_annotation.py:75: error: Cannot assign to final attribute "ID6" [misc]']
Line 112: Unexpected errors ['qualifiers_final_annotation.py:112: error: Cannot assign to final name "__private" [misc]']
Line 161: Unexpected errors ['qualifiers_final_annotation.py:161: error: Invalid "NamedTuple()" field name [misc]']
Line 163: Unexpected errors ['qualifiers_final_annotation.py:163: error: Unexpected keyword argument "x" for "N" [call-arg]', 'qualifiers_final_annotation.py:163: error: Unexpected keyword argument "y" for "N" [call-arg]']
"""
63 changes: 33 additions & 30 deletions conformance/results/pycroscope/qualifiers_final_annotation.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,34 +2,37 @@ conformance_automated = "Pass"
errors_diff = """
"""
output = """
./qualifiers_final_annotation.py:16:6: Final annotation without assignment requires an explicit type [invalid_qualifier]
./qualifiers_final_annotation.py:18:6: Invalid type annotation (<class 'str'>, <class 'int'>) [invalid_annotation]
./qualifiers_final_annotation.py:34:9: Final annotation without assignment requires an explicit type [invalid_qualifier]
./qualifiers_final_annotation.py:34:4: Final class attributes without initializers must be assigned in __init__ [invalid_qualifier]
./qualifiers_final_annotation.py:38:4: Final class attributes without initializers must be assigned in __init__ [invalid_qualifier]
./qualifiers_final_annotation.py:54:8: Cannot assign to final name ID5 [incompatible_assignment]
./qualifiers_final_annotation.py:62:18: Final instance attributes may be declared only in __init__ [invalid_qualifier]
./qualifiers_final_annotation.py:63:18: Final instance attributes may be declared only in __init__ [invalid_qualifier]
./qualifiers_final_annotation.py:65:8: Cannot assign to final name ID7 [incompatible_assignment]
./qualifiers_final_annotation.py:67:8: Cannot assign to final name ID7 [incompatible_assignment]
./qualifiers_final_annotation.py:71:0: Cannot assign to final name RATE [incompatible_assignment]
./qualifiers_final_annotation.py:81:0: Cannot assign to final name DEFAULT_ID [incompatible_assignment]
./qualifiers_final_annotation.py:94:4: Cannot override final attribute BORDER_WIDTH [incompatible_override]
./qualifiers_final_annotation.py:107:12: Final cannot be combined with ClassVar [invalid_qualifier]
./qualifiers_final_annotation.py:108:12: Final cannot be combined with ClassVar [invalid_qualifier]
./qualifiers_final_annotation.py:118:3: Unrecognized annotation typing.Final[<class 'int'>] [invalid_annotation]
./qualifiers_final_annotation.py:121:13: Unexpected Final annotation [invalid_qualifier]
./qualifiers_final_annotation.py:131:7: Unexpected Final annotation [invalid_qualifier]
./qualifiers_final_annotation.py:136:4: Final class attributes without initializers must be assigned in __init__ [invalid_qualifier]
./qualifiers_final_annotation.py:148:0: In call to pycroscope.signature.N: Missing required argument 'x' [incompatible_call]
./qualifiers_final_annotation.py:149:4: Incompatible argument type for x: expected int but got Literal[''] [incompatible_argument]
./qualifiers_final_annotation.py:149:10: Incompatible argument type for y: expected int but got Literal[''] [incompatible_argument]
./qualifiers_final_annotation.py:155:4: Cannot assign to final name ID1 [incompatible_assignment]
./qualifiers_final_annotation.py:159:4: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:161:9: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:163:8: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:166:29: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:169:8: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:180:0: Cannot assign to final name TEN [incompatible_assignment]
./qualifiers_final_annotation.py:184:0: Cannot assign to final name PI [incompatible_assignment]
./qualifiers_final_annotation.py:20:12: Incompatible argument type for x: expected Literal[1] but got int [incompatible_argument]
./qualifiers_final_annotation.py:23:12: Incompatible argument type for x: expected Literal[1] but got int [incompatible_argument]
./qualifiers_final_annotation.py:26:12: Literal[range(0, 1)] is not equivalent to range
./qualifiers_final_annotation.py:32:6: Final annotation without assignment requires an explicit type [invalid_qualifier]
./qualifiers_final_annotation.py:34:6: Invalid type annotation (<class 'str'>, <class 'int'>) [invalid_annotation]
./qualifiers_final_annotation.py:50:9: Final annotation without assignment requires an explicit type [invalid_qualifier]
./qualifiers_final_annotation.py:50:4: Final class attributes without initializers must be assigned in __init__ [invalid_qualifier]
./qualifiers_final_annotation.py:54:4: Final class attributes without initializers must be assigned in __init__ [invalid_qualifier]
./qualifiers_final_annotation.py:70:8: Cannot assign to final name ID5 [incompatible_assignment]
./qualifiers_final_annotation.py:78:18: Final instance attributes may be declared only in __init__ [invalid_qualifier]
./qualifiers_final_annotation.py:79:18: Final instance attributes may be declared only in __init__ [invalid_qualifier]
./qualifiers_final_annotation.py:81:8: Cannot assign to final name ID7 [incompatible_assignment]
./qualifiers_final_annotation.py:83:8: Cannot assign to final name ID7 [incompatible_assignment]
./qualifiers_final_annotation.py:87:0: Cannot assign to final name RATE [incompatible_assignment]
./qualifiers_final_annotation.py:97:0: Cannot assign to final name DEFAULT_ID [incompatible_assignment]
./qualifiers_final_annotation.py:110:4: Cannot override final attribute BORDER_WIDTH [incompatible_override]
./qualifiers_final_annotation.py:123:12: Final cannot be combined with ClassVar [invalid_qualifier]
./qualifiers_final_annotation.py:124:12: Final cannot be combined with ClassVar [invalid_qualifier]
./qualifiers_final_annotation.py:134:3: Unrecognized annotation typing.Final[<class 'int'>] [invalid_annotation]
./qualifiers_final_annotation.py:137:13: Unexpected Final annotation [invalid_qualifier]
./qualifiers_final_annotation.py:147:7: Unexpected Final annotation [invalid_qualifier]
./qualifiers_final_annotation.py:152:4: Final class attributes without initializers must be assigned in __init__ [invalid_qualifier]
./qualifiers_final_annotation.py:164:0: In call to pycroscope.signature.N: Missing required argument 'x' [incompatible_call]
./qualifiers_final_annotation.py:165:4: Incompatible argument type for x: expected int but got Literal[''] [incompatible_argument]
./qualifiers_final_annotation.py:165:10: Incompatible argument type for y: expected int but got Literal[''] [incompatible_argument]
./qualifiers_final_annotation.py:171:4: Cannot assign to final name ID1 [incompatible_assignment]
./qualifiers_final_annotation.py:175:4: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:177:9: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:179:8: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:182:29: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:185:8: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:196:0: Cannot assign to final name TEN [incompatible_assignment]
./qualifiers_final_annotation.py:200:0: Cannot assign to final name PI [incompatible_assignment]
"""
Loading