Skip to content

Fix return types in tkinter.filedialog #16689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hrithiksaini99 wants to merge 1 commit into from
Closed

Fix return types in tkinter.filedialog #16689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions stdlib/@tests/test_cases/check_tkinter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@

import sys
import tkinter
import tkinter.filedialog
import traceback
import types
from typing import Literal
from typing_extensions import assert_type


Expand Down Expand Up @@ -71,3 +73,8 @@ def foo(x: int, y: str) -> None:
t.count("1.0", "2.3", "indices", "lines", "chars", "ypixels", return_ints=True), tuple[int, ...]
) # (15, 1, 15, 19)
assert_type(t.count("2.3", "2.3", "indices", "lines", "chars", "ypixels", return_ints=True), tuple[int, ...]) # (0, 0, 0, 0)

assert_type(tkinter.filedialog.askopenfilename(), str | tuple[()])
assert_type(tkinter.filedialog.asksaveasfilename(), str | tuple[()])
assert_type(tkinter.filedialog.askdirectory(), str | tuple[()])
assert_type(tkinter.filedialog.askopenfilenames(), Literal[""] | tuple[str, ...])
6 changes: 3 additions & 3 deletions stdlib/tkinter/filedialog.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def asksaveasfilename(
parent: Misc | None = None,
title: str | None = None,
typevariable: StringVar | str | None = None,
) -> str: ... # can be empty string
) -> str | tuple[()]: ... # can be empty string or empty tuple
def askopenfilename(
*,
defaultextension: str | None = "",
Expand All @@ -96,7 +96,7 @@ def askopenfilename(
parent: Misc | None = None,
title: str | None = None,
typevariable: StringVar | str | None = None,
) -> str: ... # can be empty string
) -> str | tuple[()]: ... # can be empty string or empty tuple
def askopenfilenames(
*,
defaultextension: str | None = "",
Expand All @@ -113,7 +113,7 @@ def askdirectory(
mustexist: bool | None = False,
parent: Misc | None = None,
title: str | None = None,
) -> str: ... # can be empty string
) -> str | tuple[()]: ... # can be empty string or empty tuple

# TODO: If someone actually uses these, overload to have the actual return type of open(..., mode)
def asksaveasfile(
Expand Down
Loading