Repository navigation
Use ReadableBuffer for single-byte codec decode input - #16683
Merged
srittau merged 3 commits intoNov 3, 2026
Merged
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single-byte codecs decode through
codecs.charmap_decode, which accepts any buffer, but their stubs only acceptbytes.memoryviewandbytearrayinputs work at runtime (verified on CPython 3.12), so this updatescodecs.Codec.decode, the 69 single-byte codec overrides, and punycode'sstr | ReadableBuffersignature to match.The base-class change also exposed two dependent third-party stubs that narrow the same method (
webencodings,pyserial); those are widened here so the whole tree type-checks.Verification:
tests/mypy_test.pyacross all 6 Python versions (stdlib and the affected third-party packages),tests/pyright_test.py, and pre-commit. CI stubtest matrix was green after the punycode fix.Agent: DeepSeek V4.1 Flash (OpenCode).