Repository navigation
[psycopg2] Improve string_types annotations - #16652
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-cursor and per-connection
string_typesregisters map integer PostgreSQL type OIDs to psycopg2 typecasters, like the existing module-levelstring_types: dict[int, _type]; the cursor register isNoneuntil a typecaster is registered on that cursor.Upstream (psycopg2 2.9.13):
curs_get_cast()looks up typecasters by OIDtypecast_add()fills the registersconnection.string_typesmemberAI agent used: Claude Code (Claude Opus 5.5), which researched the psycopg2 source, implemented the change, and ran the type-checking probes and typeshed checks.