Skip to content

[tkinter] filedialog ask* functions can return an empty tuple when cancelled #16642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Akuli merged 2 commits into from
Nov 4, 2026
Merged

[tkinter] filedialog ask* functions can return an empty tuple when cancelled #16642

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a24856
[tkinter] filedialog ask* functions can return an empty tuple when ca…
hoangchunghien Oct 29, 2026
b37beaa
Remove the filedialog test cases
hoangchunghien Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions stdlib/tkinter/filedialog.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def asksaveasfilename(
parent: Misc | None = None,
title: str | None = None,
typevariable: StringVar | str | None = None,
) -> str: ... # can be empty string
) -> str | tuple[()]: ... # empty string or empty tuple if cancelled, depending on the Tk version
def askopenfilename(
*,
defaultextension: str | None = "",
Expand All @@ -96,7 +96,7 @@ def askopenfilename(
parent: Misc | None = None,
title: str | None = None,
typevariable: StringVar | str | None = None,
) -> str: ... # can be empty string
) -> str | tuple[()]: ... # empty string or empty tuple if cancelled, depending on the Tk version
def askopenfilenames(
*,
defaultextension: str | None = "",
Expand All @@ -113,7 +113,7 @@ def askdirectory(
mustexist: bool | None = False,
parent: Misc | None = None,
title: str | None = None,
) -> str: ... # can be empty string
) -> str | tuple[()]: ... # empty string or empty tuple if cancelled, depending on the Tk version

# TODO: If someone actually uses these, overload to have the actual return type of open(..., mode)
def asksaveasfile(
Expand Down
Loading