Repository navigation
[shapely] Changes for new features and updates made in Release 2.2.0 - #16562
jack-volantautonomy wants to merge 13 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thanks for picking this up! A few things from checking against shapely 2.2.0 at runtime:
|
This comment has been minimized.
This comment has been minimized.
|
Hey @thomas-maschler, sorry for not getting to this sooner but thanks for the help, much appreciated! I'm fairly new to typeshed work and wasn't aware of the allowlist so that was a great help as it was getting pretty tiring! I think the PR is much more ready now after working through your comment and finishing off the remaining stuff. Marking it as ready for review and would be great if you could take another look. Cheers 👍 |
This comment has been minimized.
This comment has been minimized.
thomas-maschler
left a comment
There was a problem hiding this comment.
Thanks, this looks much better! The stubtest items are all resolved. I left a few inline suggestions; two more things outside the diff:
prepareanddestroy_preparedincreation.pyinow returnbool(#2359) but are still typed-> None.ops.transform(DeprecationWarning) anddecorators.multithreading_enabled(FutureWarning) are deprecated in 2.2.0 and could get@deprecated.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This PR aims to provide type support for the latest
2.2.0release in shapely which comes with new features, deprecations, and more tweaks.