Skip to content

Automatic code owners / reviewers / per-stubs notifications #16663

Closed

Description

@Avasam

There's a lot of stubs in typeshed. And there's a lot of active, dedicated contributors with specialized knowledge.

I, for example, am actually interested in receiving a notification whenever something touches:

  • setuptools / distutils
  • pywin32
  • pyinstaller
  • python-xlib
  • keyboard
  • PyAutoGUI
  • ...

So I can help review those faster, despite not having a ton of time to give to typeshed anymore (so I'm not already scouring open PRs weekly).

And maybe more stubs I regularly use (qrcode, pynput) I wouldn't mind speeding up improvements once in a while.

Although I don't wanna create too much extra churn just maintaining lists of codeowners and such (maintainers can change a CODEOWNERS file, but contributors can't).

Any recommendations ?

Activity

  1. added and removed
    project: policyOrganization of the typeshed project
    on Oct 30, 2026
  2. AlexWaygood commented on Nov 2, 2026

    @AlexWaygood
    Member

    Seems fine to me to add a CODEOWNERS file if it'll be helpful for you and/or others! I'm not sure it'll be too helpful for me personally but I don't think it'll disrupt my workflow at all either

  3. Avasam commented on Nov 2, 2026

    @Avasam
    SponsorCollaboratorAuthor

    Maintainers can add and remove themselves as much as they'd want directly in a CODEOWNERS file (no need for review really). Shouldn't bother anyone other than a bit of git history churn.
    It should also be made clear that it's not about "owning" the code, but simply about getting automated review requests.

    I'm just wondering what about non-"maintainer" contributors. That are active in developing/maintaining some stubs. Especially those who provided the stubs themselves and want to stay involved. What would be the policy there ?

  4. srittau commented on Nov 2, 2026

    @srittau
    Collaborator

    I'm just wondering what about non-"maintainer" contributors. That are active in developing/maintaining some stubs. Especially those who provided the stubs themselves and want to stay involved. What would be the policy there ?

    I think we should accept trusted contributors there as well.

  5. Avasam commented on Nov 3, 2026

    @Avasam
    SponsorCollaboratorAuthor

    Opened #16690

    I also just realize, maintainers could subscribe to changes to the contribution or maintainers guide with this.
    I'm sure I've missed some updates in the past, and typeshed's best practices is constantly evolving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions