Skip to content

Don't show unpublished releases as superseded - #3195

Merged
JacobCoffee merged 1 commit into
python:mainfrom
hugovk:unpublished-not-superseded
Oct 21, 2026
Merged

JacobCoffee merged 1 commit into
python:mainfrom
hugovk:unpublished-not-superseded

Conversation

@hugovk

@hugovk hugovk commented Oct 21, 2026

Copy link
Copy Markdown
Member

Description

Before:

With a published release:

image

But an unpublished release shows it has been superseded by the earlier one:

image

After:

No change to published release:

image

Don't show the notice on the unpublished one:

image

@hugovk
hugovk requested a review from JacobCoffee as a code owner October 21, 2026 15:31
Copilot AI balanced review requested due to automatic review settings October 21, 2026 15:31
@JacobCoffee
JacobCoffee enabled auto-merge October 21, 2026 15:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused guard and regression test address the reported issue without changing published-release behavior.

No open issues 🎉

What changed in this PR

Prevents unpublished release pages from showing a misleading “superseded by” notice while preserving published-release behavior.

Changes:

  • Restricts superseded-release lookup to published releases.
  • Adds a regression test confirming draft releases omit the notice and related context.
File Description
apps/​downloads/​views.py Adds the publication guard and explains draft handling.
apps/​downloads/​tests/​test_views.py Tests that draft releases are not shown as superseded.

Review effort: Balanced

@JacobCoffee
JacobCoffee added this pull request to the merge queue Oct 21, 2026
Merged via the queue into python:main with commit 7317f84 Oct 21, 2026
6 checks passed
@hugovk
hugovk deleted the unpublished-not-superseded branch October 21, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants