Repository navigation
Avoid unnecessary setattr lookups - #22270
Merged
Merged
Conversation
This makes mypy 10% faster on the colour-science/colour codebase
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
Hmm that's a little annoying. I guess I could just land the optimisation and punt on the "correctness" issue |
Member
|
Btw I can confirm this also affects some other protocol-heavy libraries, let's just focus on the optimization part. |
Member
|
Btw a (much) better performance fix is to delete all the bizarre logic from |
Collaborator
Author
|
Yeah I was looking at that redefinition one too. Will definitely at least put up an optimisation PR for it |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes mypy 13% faster on the colour-science/colour codebase. Codex claims it's worth 0.8% on self check too.
Co-authored by Codex