Repository navigation
[mypyc] Fix crash when exception variable is captured by nested function - #22249
Merged
Merged
Conversation
Fixes mypyc/mypyc#1184. This crashed with "unexpected type DeletedType": ```python def f() -> None: try: raise RuntimeError() except RuntimeError as exc: fn = lambda: print(exc) ``` Mypy gives the variable of an except clause the type `DeletedType` after the except block, and this type is used when adding a captured variable to the environment class of the function. Now we map `DeletedType` to `object`.
p-sawicki
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mypyc/mypyc#1184.
This crashed with "unexpected type DeletedType":
Mypy gives the variable of an except clause the type
DeletedTypeafter the except block, and this type is used when adding a captured variable to the environment class of the function. Now we mapDeletedTypetoobject.