[rheard]

Fixes mypyc/mypyc#1233

for loops over lists, tuples, strings, bytes, dicts and range() (also inside enumerate(), zip() and reversed()) read the iterable, or the end of the range, on every iteration. When it was a local variable, the loop read the variable's register, so assigning to the variable in the loop body changed the iteration: for i in range(n): n = 0 ran once, for x in a: a = [9] stopped after the first item, and a loop over a tuple read past the end of the new tuple, which could segfault.

Now, if the loop target or body assigns to the local variable that holds the iterable or the end of the range, its value is copied to a new register before the loop. A small AST visitor finds these assignments: plain, augmented and starred assignments, :=, del, for targets, with ... as, except ... as and match capture patterns. Other loops generate the same IR as before. Copying unconditionally would add a copy to every loop over a local variable and change the IR of 23 existing test cases.

The comprehension form, [x for x in t if (t := (9,))], is fixed separately by #22133.

[p-sawicki]

thanks!