Skip to content

Apply signature hooks to decorator applications #21912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afonsojanu wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −0
Open

Apply signature hooks to decorator applications #21912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mypy/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5864,6 +5864,10 @@ def visit_decorator_inner(
object_type = self.lookup_type(d.expr)
fullname = self.expr_checker.method_fullname(object_type, d.name)
self.check_for_untyped_decorator(e.func, dec, d)
if fullname:
dec = self.expr_checker.transform_callee_type(
fullname, dec, [temp], [nodes.ARG_POS], e, object_type=object_type
)
sig, t2 = self.expr_checker.check_call(
dec, [temp], [nodes.ARG_POS], e, callable_name=fullname, object_type=object_type
)
Expand Down
13 changes: 13 additions & 0 deletions test-data/unit/check-custom-plugin.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,6 +908,19 @@ reveal_type(dynamic_signature(b)) # N: Revealed type is "builtins.bytes"
\[mypy]
plugins=<ROOT>/test-data/unit/plugins/function_sig_hook.py

[case testFunctionSigHookCalledOnDecorator]
# flags: --config-file tmp/mypy.ini

def dynamic_signature(arg1: str) -> str: ...

@dynamic_signature
def f() -> None: ...

reveal_type(f) # N: Revealed type is "def ()"
[file mypy.ini]
\[mypy]
plugins=<ROOT>/test-data/unit/plugins/function_sig_hook.py

[case testPluginCalledCorrectlyWhenMethodInDecorator]
# flags: --config-file tmp/mypy.ini
from typing import TypeVar, Callable
Expand Down
Loading