Replace builtins.ellipsis with types.EllipsisType - #21911
Merged
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JelleZijlstra
approved these changes
Aug 29, 2026
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8240
Unblocks python/typeshed#15712
The actual change is one line in checkexpr and the other changes are for tests, mostly mechanical.
I used the try except trick used for
types.ModuleTypein the name lookup so that tests that don't import thetypesmodule don't crash withKeyErrorwhen they use...(which is used in almost all tests as empty function body).Most test changes are caused by modules now correctly resolving to module type instead of
objectbecause some fixtures started importingtypes.The changes are mine, I only used a coding agent to fix the
fine-grained-modules.testandtestexportjson.pytests and the missing visitor method.