Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/bdb.py
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,7 @@ def clear_all_file_breaks(self, filename):
return 'There are no breakpoints in %s' % filename
for line in self.breaks[filename]:
blist = Breakpoint.bplist[filename, line]
for bp in blist:
for bp in blist[:]:
bp.deleteMe()
del self.breaks[filename]
return None
Expand Down
11 changes: 11 additions & 0 deletions Lib/test/test_bdb.py
Original file line number Diff line number Diff line change
Expand Up @@ -965,6 +965,17 @@ def main():
with TracerRun(self) as tracer:
tracer.runcall(tfunc_import)

def test_clear_all_file_breaks_same_line(self):
reset_Breakpoint()
self.addCleanup(reset_Breakpoint)
debugger = Bdb()
for _ in range(3):
self.assertIsNone(debugger.set_break(__file__, 1))
self.assertIsNone(debugger.clear_all_file_breaks(__file__))
self.assertEqual(debugger.get_all_breaks(), {})
self.assertEqual(_bdb.Breakpoint.bplist, {})
self.assertTrue(all(bp is None for bp in _bdb.Breakpoint.bpbynumber))

def test_clear_at_no_bp(self):
self.expect_set = [
('line', 2, 'tfunc_import'), ('clear', (__file__, 1))
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix :meth:`bdb.Bdb.clear_all_file_breaks` leaving breakpoints behind when
multiple breakpoints are set on the same line.
Loading