Skip to content

gh-149015: Fix clear_all_file_breaks for breakpoints sharing a line in bdb - #159748

Merged
gaogaotiantian merged 1 commit into
python:mainfrom
gaogaotiantian:fix-149015-bdb-clear-file-breaks
Oct 19, 2026
Merged

gaogaotiantian merged 1 commit into
python:mainfrom
gaogaotiantian:fix-149015-bdb-clear-file-breaks

Conversation

@gaogaotiantian

@gaogaotiantian gaogaotiantian commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Fixes #149015.

Iterate over a copy of the breakpoint list in Bdb.clear_all_file_breaks(), matching clear_break(), so deleting breakpoints does not skip entries on the same line. Add a compact regression test checking that the debugger and both breakpoint registries are cleared, plus a NEWS entry.

Validation: ./python.exe -m test -v test_bdb (37 tests passed).

AI assistance was used to prepare the patch and regression test.

@gaogaotiantian gaogaotiantian added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 19, 2026
@gaogaotiantian gaogaotiantian changed the title gh-149015: Clear all breakpoints sharing a line in bdb gh-149015: Fix clear_all_file_breaks for breakpoints sharing a line in bdb Oct 19, 2026
@gaogaotiantian
gaogaotiantian merged commit 630920e into python:main Oct 19, 2026
59 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@gaogaotiantian
gaogaotiantian deleted the fix-149015-bdb-clear-file-breaks branch October 19, 2026 22:03
@bedevere-app

bedevere-app Bot commented Oct 19, 2026

Copy link
Copy Markdown

GH-159801 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 19, 2026
@bedevere-app

bedevere-app Bot commented Oct 19, 2026

Copy link
Copy Markdown

GH-159802 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 19, 2026
gaogaotiantian added a commit that referenced this pull request Oct 19, 2026
… line in bdb (GH-159748) (#159801)

gh-149015: Fix clear_all_file_breaks for breakpoints sharing a line in bdb (GH-159748)
(cherry picked from commit 630920e)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
gaogaotiantian added a commit that referenced this pull request Oct 19, 2026
… line in bdb (GH-159748) (#159802)

gh-149015: Fix clear_all_file_breaks for breakpoints sharing a line in bdb (GH-159748)
(cherry picked from commit 630920e)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bdb.clear_all_file_breaks skips breakpoints when multiple breakpoints share a line

1 participant