gh-156408: Fix asyncio.print_call_graph() on a finished task - #156410
Open
deadlovelll wants to merge 1 commit into
Open
gh-156408: Fix asyncio.print_call_graph() on a finished task#156410deadlovelll wants to merge 1 commit into
deadlovelll wants to merge 1 commit into
Conversation
deadlovelll
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
August 26, 2026 09:56
aisk
reviewed
Aug 27, 2026
| elif hasattr(coro, 'ag_await'): | ||
| # A native async generator or duck-type compatible iterator | ||
| st.append(FrameCallGraphEntry(coro.ag_frame)) | ||
| coro = coro.ag_await |
Member
There was a problem hiding this comment.
This line has the same pattern as you fixed above, should we check if it's None here?
Contributor
Author
There was a problem hiding this comment.
hi! Suspended async generator always have it's frame, because it's cleared only when the generator finishes
We only get into this branch while a task is suspended inside the generator, so the generator is still alive and always has a frame
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix asyncio.print_call_graph() on a finished task
For more details see gh-156408