Skip to content

gh-89696: Fix loop.sock_connect docs on address resolution#153651

Merged
kumaraditya303 merged 1 commit into
python:mainfrom
kumaraditya303:gh-89696-sock-connect-docs
Jul 13, 2026
Merged

gh-89696: Fix loop.sock_connect docs on address resolution#153651
kumaraditya303 merged 1 commit into
python:mainfrom
kumaraditya303:gh-89696-sock-connect-docs

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@kumaraditya303
pythongh-89696: Fix loop.sock_connect docs on address resolution
b23159e 
The docs claimed unconditionally that the address no longer needs to be
resolved, but only SelectorEventLoop does that. ProactorEventLoop, the
default event loop on Windows, passes the address straight to ConnectEx()
and WSAConnect(), which parse it with WSAStringToAddress() and therefore
only accept numeric addresses.
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Jul 13, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jul 13, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 13, 2026
Closed
@kumaraditya303 kumaraditya303 added topic-asyncio needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes and removed awaiting core review labels Jul 13, 2026
@read-the-docs-community

read-the-docs-community Bot commented Jul 13, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33561236 | 📁 Comparing b23159e against main (adebb68)

  🔍 Preview build  

1 file changed
± library/asyncio-eventloop.html

@kumaraditya303 kumaraditya303 merged commit 1fece44 into python:main Jul 13, 2026
46 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jul 13, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 13, 2026

Copy link
Copy Markdown

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-app

bedevere-app Bot commented Jul 13, 2026

Copy link
Copy Markdown

GH-153652 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 13, 2026
@bedevere-app

bedevere-app Bot commented Jul 13, 2026

Copy link
Copy Markdown

GH-153653 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 13, 2026
@bedevere-app

bedevere-app Bot commented Jul 13, 2026

Copy link
Copy Markdown

GH-153654 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 13, 2026
kumaraditya303 added a commit that referenced this pull request Jul 13, 2026
@miss-islington @kumaraditya303
[3.15] gh-89696: Fix loop.sock_connect docs on address resolution (G…
9efded4 
…H-153651) (#153652)

gh-89696: Fix `loop.sock_connect` docs on address resolution (GH-153651)
(cherry picked from commit 1fece44)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
kumaraditya303 added a commit that referenced this pull request Jul 13, 2026
@miss-islington @kumaraditya303
[3.14] gh-89696: Fix loop.sock_connect docs on address resolution (G…
c628cd7 
…H-153651) (#153653)

gh-89696: Fix `loop.sock_connect` docs on address resolution (GH-153651)
(cherry picked from commit 1fece44)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
kumaraditya303 added a commit that referenced this pull request Jul 13, 2026
@miss-islington @kumaraditya303
[3.13] gh-89696: Fix loop.sock_connect docs on address resolution (G…
cd1d07a 
…H-153651) (#153654)

gh-89696: Fix `loop.sock_connect` docs on address resolution (GH-153651)
(cherry picked from commit 1fece44)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@kumaraditya303 kumaraditya303 deleted the gh-89696-sock-connect-docs branch July 13, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-asyncio

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

loop.sock_connect doesn't resolve the address parameter on Windows

1 participant

@kumaraditya303