Skip to content

gh-150195: Bump recursion limit to 300,000#150256

Closed
clin1234 wants to merge 2 commits into
python:mainfrom
clin1234:patch-8
Closed

gh-150195: Bump recursion limit to 300,000#150256
clin1234 wants to merge 2 commits into
python:mainfrom
clin1234:patch-8

Conversation

@clin1234
Copy link
Copy Markdown
Contributor

@clin1234 clin1234 commented May 22, 2026 •
edited by bedevere-app Bot
Loading

Silences AssertionError: RecursionError not raised when compiling on macOS 26 with Clang 22 with -fstack-protection-strong

@bedevere-app bedevere-app Bot mentioned this pull request May 22, 2026
Open
@picnixz
Copy link
Copy Markdown
Member

picnixz commented May 22, 2026

This will have a non-trivial effect on the overal timings so please check before/after timings for CIs and locally. Is 300k the only acceptable limit? please dig into the git history to understand why we put 150k here and if there were past choices involved there.

picnixz
picnixz requested changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the changes and investigation I asked.

Comment thread Misc/NEWS.d/next/Library/2026-05-22-15-54-44.gh-issue-150195.BxC_8y.rst
@@ -0,0 +1 @@
Bump recursion limit to 300,000
Copy link
Copy Markdown
Member

@picnixz picnixz May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dors not explain anything. You can just remove the NEWS entry.

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 27, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@picnixz picnixz added tests Tests in the Lib/test dir skip news and removed awaiting changes labels May 27, 2026
@clin1234 clin1234 closed this May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz requested changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clin1234 @picnixz