Skip to content

gh-149835: _destinsrc to use realpath instead of abspath#149986

Open
KowalskiThomas wants to merge 2 commits into
python:mainfrom
KowalskiThomas:kowalski/fix-_destinsrc-to-use-realpath-instead-of-abspath
Open

gh-149835: _destinsrc to use realpath instead of abspath#149986
KowalskiThomas wants to merge 2 commits into
python:mainfrom
KowalskiThomas:kowalski/fix-_destinsrc-to-use-realpath-instead-of-abspath

Conversation

@KowalskiThomas
Copy link
Copy Markdown
Contributor

@KowalskiThomas KowalskiThomas commented May 18, 2026

@StanFromIreland StanFromIreland changed the title fix: _destinsrc to use realpath instead of abspath gh-149835: _destinsrc to use realpath instead of abspath May 18, 2026
@StanFromIreland
Copy link
Copy Markdown
Member

Can you please pre-pend the issue number to the title in the future.

@KowalskiThomas
Copy link
Copy Markdown
Contributor Author

@StanFromIreland oh yeah right, I usually do but I forgot on this one 😅

@KowalskiThomas KowalskiThomas marked this pull request as ready for review May 18, 2026 15:49
@KowalskiThomas KowalskiThomas requested a review from giampaolo as a code owner May 18, 2026 15:49
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shutil.move can move the dir into itself (with a symlink)

3 participants