Repository navigation
Hide exec-helpers frames in pytest failure reports - #176
Open
penguinolog wants to merge 1 commit into
Open
penguinolog wants to merge 1 commit into
penguinolog wants to merge 1 commit into
Conversation
A timeout or an unexpected exit code already names the command and carries its output, so the package frames in a pytest report only push the caller's line out of view. - Add _helpers.hide_traceback, which pytest calls through a module-level __tracebackhide__. - It hides the frame for an ExecHelperError and keeps it for any other exception. - Set __tracebackhide__ in every module on the execute and check_call path. - test_timeout checks that no package frame is left; a new test checks that other errors keep them.
penguinolog
changed the title
Collaborator
Coverage Report for CI Build 41703231015Coverage increased (+0.05%) to 88.617%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A timeout or an unexpected exit code already names the command and carries its output,
so the package frames in a pytest report only push the caller's line out of view.