Allow @parcel/watcher build script in Jupyter template - #181
Merged
Conversation
jest 30.5.0 pulls in @parcel/watcher through jest-haste-map. pnpm refuses to silently skip its build script, so pnpm install fails with ERR_PNPM_IGNORED_BUILDS and the requirements-js target errors out. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Jupyter template's
make requirements-jscurrently fails onpnpm install:jest@30.5.0now pulls@parcel/watcherin throughjest-haste-map(confirmed withpnpm why). It has a build script, and pnpm refuses to skip one silently unless the package is listed inallowBuilds, so the install exits non-zero.Adding it alongside the existing entries fixes it.
@parcel/watcherresolves a prebuilt platform package rather than compiling, so this does not add a native build step.This is dependency drift rather than a regression from any particular change: main was green on 2026-08-27 and the same failure now reproduces on unrelated branches. Only the Jupyter template is affected; the other JavaScript templates allow just
esbuildand are unaffected.Verified with
make gen-jupyter, then in the generated project:pnpm installsucceeds,pnpm lintpasses, andpnpm testpasses 2/2. Also confirmed@parcel/watcherloads at runtime.