Escape content appended to a String via __add__ - #612
Open
Master-Norna wants to merge 1 commit into
Open
Master-Norna wants to merge 1 commit into
Master-Norna wants to merge 1 commit into
Conversation
String.__add__ spliced the appended text into the raw literal without escaping it, so appending a quote or backslash to a basic string produced a literal that is not valid TOML - including to this library's own parser. Escape the appended plain text with the string type's escape sequences (a String operand keeps contributing its already-escaped raw form), mirroring what from_raw already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
String.__add__spliced the appended text into the raw literal without escaping it, so appending a quote or backslash to a basic string produced a literal that is not valid TOML - including to this library's own parser:Escape the appended plain text with the string type's escape sequences (a
Stringoperand keeps contributing its already-escaped raw form), mirroring whatfrom_rawalready does. This is the same class of bug as #231, which fixed the literal round-trip but not__add__.Agent Drafting Metadata