Skip to content

test: accept compatible extension wheel tags - #11014

Open
NgoQuocViet2001 wants to merge 1 commit into
python-poetry:mainfrom
NgoQuocViet2001:fix-compatible-extension-wheel-tags
Open

test: accept compatible extension wheel tags#11014
NgoQuocViet2001 wants to merge 1 commit into
python-poetry:mainfrom
NgoQuocViet2001:fix-compatible-extension-wheel-tags

Conversation

@NgoQuocViet2001

Copy link
Copy Markdown

Resolves: #11013

Summary

  • Parse the generated extension wheel filename instead of assuming the build backend selects the first supported tag.
  • Keep assertions for the distribution name and version, and verify that the generated wheel has at least one tag supported by the environment.

Tests

  • Added tests for changed code.
  • Updated documentation for changed code. (Not applicable; test-only change.)

Ran: poetry run pytest -q -p no:randomly -n 0 tests/installation/test_chef.py

Ran: poetry run pre-commit run --files tests/installation/test_chef.py

Ran: poetry run mypy tests/installation/test_chef.py

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Packaging now prefers native linux_* platform tags

1 participant