Fix: GenericEnv.is_venv() in src/poetry/utils/env/generic_env.py compared...

[M001N]

Summary

Changed is_venv() to resolve both paths before comparing: return self._path.resolve() != self._base.resolve().

Problem

python-poetry/poetry issue reference: #10991

Root Cause

GenericEnv.is_venv() in src/poetry/utils/env/generic_env.py compared self._path and self._base with plain inequality (self._path != self._base) without resolving symlinks/aliases. When a Python version manager exposes the same interpreter via two different filesystem paths (e.g. an unversioned symlink and the concrete versioned directory it points to), the unresolved paths differ even though they refer to the same interpreter, so is_venv() incorrectly returns True. This causes EnvManager.create_venv() to believe Poetry is already running inside an isolated virtualenv and skip creating a project-specific venv.

Testing

PASS - 35 passed, 1 skipped (pre-existing nix-only symlink test skipped on Windows); new test also independently verified to fail on unmodified code and pass with the fix.

Related Issue

#10991

[sourcery-ai]

Hey - I've left some high level feedback:

• Using Path.resolve() on every is_venv() call introduces filesystem access and potential exceptions if either path is missing; consider pre-normalizing/caching resolved paths at construction time or handling resolution failures explicitly.
• The new test reaches into env._path and env._base directly, which couples it to internals; if possible, construct the GenericEnv in a way that reflects realistic initialization while still exercising the aliasing behavior, to avoid future brittleness when internals change.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Using `Path.resolve()` on every `is_venv()` call introduces filesystem access and potential exceptions if either path is missing; consider pre-normalizing/caching resolved paths at construction time or handling resolution failures explicitly.
- The new test reaches into `env._path` and `env._base` directly, which couples it to internals; if possible, construct the `GenericEnv` in a way that reflects realistic initialization while still exercising the aliasing behavior, to avoid future brittleness when internals change.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}