solver: fix KeyError due to orphan decisions - #11008
Draft
radoering wants to merge 1 commit into
Draft
Conversation
This only fixes the symptom (in some cases - see xfail tests) but not the root cause.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only fixes the symptom (in some cases - see xfail tests) but not the root cause.
The issue occurs when two builds share a base version and differ only by a local segment, e.g.
torch 2.12.1, which requirestriton, and atorch 2.12.1+cpubuild, which does not. While backtracking, the solver records the incompatibilities of the2.12.1build and then settles on2.12.1+cpu. Since a local segment is ignored by==,2.12.1+cpusatisfies the termtorch (==2.12.1), so the discarded build's incompatibilities keep deriving its transitive dependencies, which are left behind as orphan decisions. They must not be carried into the solution.With this change we just ignore such orphan decisions. However, they can still let the resolution fail if they conflict (or do not exist).
Pull Request Check List
Resolves: #10965