Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #496.
Changes proposed in this pull request:
Decimalwhenndigitsis omitted and the string has no exponent, then apply the existing grouping and locale separators. For example,"1234567890123456.78"becomes"1,234,567,890,123,456.78".ndigits, exponent inputs, invalid-string fallback and non-finite handling keep their existing paths.Validation: the precision tests fail on the original code; the patch passes all 893 tests, 15 separate doctests, Ruff, Black and mypy. An independent check with a different long fractional string also passed in English, German and French.
The unmodified
tox -e pycommand hit 15 benchmark setup errors with pytest 9.2.0 / pytest-codspeed 5.0.4 (Function._nodeidwas removed). Recreating that single tox environment with a local pytest 9.0.2 installation constraint passed all 893 tests against the installed sdist. No repository dependency or tox configuration changes are included. The complete source-environment suite also passed with network access disabled. Windows, the multi-interpreter tox matrix, the full prek hook set and docs build were not run.