-
-
Notifications
You must be signed in to change notification settings - Fork 756
Add support for replies to help snippets #3538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Saber0324
wants to merge
13
commits into
python-discord:main
Choose a base branch
from
Saber0324:add-reply
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−8
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ba68ec4
Added get_reference_message helper
5a42d7c
Implemented get_reference_message in get_command_ctx
6f61da0
Moved the ctx.send variant of get_command_ctx to the else branch
f181232
Moved get_reference message from ext/info/tags.py to utils/messages.py
5a298e4
Added functionality from get_reference_message
c202ee2
Added send_or_reply helper
fb037ac
Make send_or_reply return the discord.Message instead of None
d50401d
Change the use of bare get_reference_message for the send_or_reply he…
a94def3
Refactor get_reference_message to avoid fetching messages manually an…
b87be07
Add a check for referece.message_id for fetch_message to not complain…
8e827ec
Reconstruct the reference to avoid HTTPException in case the reply ca…
f51d3bd
Update the docstring to match current behavior
106f32f
Fix the send_or_reply indentation
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -7,7 +7,7 @@ | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| from itertools import zip_longest | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| import discord | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| from discord import Message | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| from discord import DeletedReferencedMessage, Embed, Message | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| from discord.ext.commands import Context | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| from pydis_core.site_api import ResponseCodeError | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| from pydis_core.utils import scheduling | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
@@ -285,3 +285,35 @@ async def upload_log( | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| raise | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| return f"{URLs.site_logs_view}/{response['id']}" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| async def get_reference_message(ctx: Context) -> Message | None: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| """Return a message reference if the reference exists and it does not refer to the author of the message.""" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| if (ctx.message.reference is None | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| or ctx.message.reference.message_id is None): | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| return None | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| try: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| referenced_message = ( | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| ctx.message.reference.resolved | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| or ctx.message.reference.cached_message | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| or await ctx.fetch_message(ctx.message.reference.message_id) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| except (discord.Forbidden, discord.NotFound): | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| return None | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| else: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| if referenced_message is None or isinstance(referenced_message, DeletedReferencedMessage): | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| return None | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| if referenced_message.author == ctx.author: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| return None | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| return referenced_message | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+289
to
+307
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sorry if wasn't very clear,
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| async def send_or_reply(ctx: Context, embed: Embed) -> Message: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| """ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Sends the bot message as a reply if the callers message has a reference. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| If the callers message does not have a reference or the reference is deleted, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| the bot messsage is sent without replying. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| """ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| if message_reference := await get_reference_message(ctx): | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| reference = message_reference.to_reference(fail_if_not_exists=False) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| return await ctx.send(embed=embed, reference=reference) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| return await ctx.send(embed=embed) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this looks gud now, just one minor nit:
referenced_messagecan never beNonehere as ifresolvedorcached_messageis None, we will fetch using the API, which will raiseNotFoundetc. if the message can't be fetched.